461890 - Shortcut for "Hide Application" differ from the standard mac key combo

Status: RESOLVED FIXED

(Mozilla Localizations :: uk / Ukrainian, defect)

Description

[Stefan [:stefanh]]

(filing one bug per locale, please see the list below for your locale)


The mac shortcut keys for hiding the current application is a fairly standardized shortcut combo (accel+H). The same goes for "Hide all other applications" (accel+alt+H). Doing a mxr search for "hideThisAppCmdMac.commandkey" in l10n, shows quite a few locales that has different keys. Note that for some locales there might be exceptions (ar and el maybe?), but I think most of the locales should use "H". Note also that the keys for opening preferences and quitting the application are also standardized on mac afaik.


Summary: (locale and directory)

af - browser
ar - browser
bg - browser
da - browser
de - calendar
el - browser
es-AR - mail
et - calendar
fr - mail, calendar
fy-NL = browser, mail, calendar
id - mail
is - calendar
it - mail, calendar
ku - browser
nb-NO and nn-NO - mail, calendar
nl - mail, calendar
pl - mail, calendar
pt-PT - browser, mail, calendar
sr - mail
tr - mail, calendar
uk - calendar

Summary:

The following keys are standardized:

hideThisAppCmdMac.commandkey (accel+H)
hideOtherAppsCmdMac.commandkey (accel+alt+H)
preferencesCmdMac.commandkey (accel+,"
"Quit" commandkey (doesn't have the entity handy atm, the keys are accel+Q).

Note: I haven't checked suite/ yet because the entities are named different.

Comment 1

[Stefan [:stefanh]]

ouch,
> preferencesCmdMac.commandkey (accel+,"

should be (accel+,)

Comment 2

[Stefan [:stefanh]]

> The following keys are standardized:
> 
> hideThisAppCmdMac.commandkey (accel+H)
> hideOtherAppsCmdMac.commandkey (accel+alt+H)
> preferencesCmdMac.commandkey (accel+,"
> "Quit" commandkey (doesn't have the entity handy atm, the keys are accel+Q).

I think I might have added some confusion with the above lines. I was actually talking about the key combo that you press and not just the commandkey. I other words, I don't mean that "hideThisAppCmdMac.commandkey (accel+H)" should be "accel+H", it should of course be "H" and "hideThisAppCmdMac.modifiers" should be "accel".

So, it should look like this:

<!ENTITY preferencesCmdMac.commandkey   ",">
<!ENTITY preferencesCmdMac.modifiers    "accel">
<!ENTITY hideThisAppCmdMac.commandkey   "H">
<!ENTITY hideThisAppCmdMac.modifiers    "accel">
<!ENTITY hideOtherAppsCmdMac.commandkey "H">
<!ENTITY hideOtherAppsCmdMac.modifiers  "accel,alt">

And the Quit commandkey should be "Q", and if there's a corresponding .modifiers entity it should be "accel" (IIRC there is a .modifiers entity for Quit in suite/, but I'm unsure if the other apps have it)

Comment 3

[Stefan [:stefanh]]

This is still an issue for mail/. Not sure if the issue have moved from calendar/ to mail since calendar/ looks ok.

Comment 4

[Stefan [:stefanh]]

/uk/mail/chrome/messenger/messenger.dtd

860 <!ENTITY hideThisAppCmdMac.commandkey   "С">
863 <!ENTITY hideOtherAppsCmdMac.commandkey "х">

These should all be "H"

Comment 5

[Tim Babych]

Thank you, Stefan.

Comment 6

[Stefan [:stefanh]]

(In reply to Tim Babych from comment #5)
> Thank you, Stefan.

No problem. Feel free to resolve the bug as fixed when you're done :-)

Comment 7

[Artem Polivanchuk]

Just fixed all the shortcuts "*CmdMac.commandkey" for uk.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/uk/rev/5d863c543b77