461906 - Shutdown hang caused by <video> tag

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Steps to reproduce:
1. Load the testcase.
2. Cmd+Q.

Result: Firefox hangs trying to shut down.

This prevents me from seriously testing the <video> tag, and I know there are sg:critical bugs lurking.

Related to bug 452097?

Comment 1

[cajbir (:cajbir)]

It's because there is no error checking on the reading of the file contained in the src, and the decoder loop gets stuck trying to find valid data. The fix for this was in bug 449159 but was removed before landing at the reviewers request. I'll recover the patch for it and fix soon.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Possibly also related to bug 452698 (to the crash that happens on quit).

Comment 3

[Steven Michaud [:smichaud] (Retired)]

> Possibly also related to bug 452698 (to the crash that happens on quit).

Possibly also related to bug 452698 (to the *hang* that happens on quit).

Comment 4

[cajbir (:cajbir)]

I've tracked this down to a liboggplay bug:

http://trac.annodex.net/ticket/435

Comment 5

[cajbir (:cajbir)]

Bug 462409 has landed which resolves the liboggplay bug. The shutdown should no longer occur. Can you confirm?

Comment 6

[cajbir (:cajbir)]

Erm, The 'shutdown hang' should no longer occur :-)

Comment 7

[Jesse Ruderman]

Well, it leaks a some thing (nsOggDecoder, nsPrincipal, and more) but it doesn't hang any more.