46192 - [SKINS] Mac Classic Skin: Preference panel titles are hard to read

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Andrew Thompson]

Moz build 2000072113

Open the preferences. The title at the top of each preference panel, which is 
displayed as "white on dark blue" in the Modern skin is hard to read in the Mac 
Classic skin because its now displayed as white to dark grey.

Change it to black?

Comment 1

[Andrew Thompson]

The text colour can be corrected by editing skins/classic/communicator/skin/
dialogOverlay.css as follows:

Change the color attribute to black in:

.box-smallheader-left
.box-smallheader-right 
.box-header-text 

More interestingly one can ask why the Modern skin has a stripy background image 
in this area whereas the classic skin does not. I think it would look good with 
the blue/marble effect seen at the top of the classic sidebar 
(this image: skins/classic/communicator/skin/smallheader-bg.gif)

Its tempting just to add this to dialogOverlay.css, but this doesn't answer the 
question of why there is no image as there is in the Modern skin, especially 
since the Modern version of dialogOverlay.css doesn't specify an image.

It turns out that if you trace back through dialogBindings.xml the title box is 
put into the class .toolbar-primary which is defined in toolbar.css for the 
Modern skin. This includes the stripy blue and black background image.

In the (Mac) Classic skin toolbar.css is heavily edited then entirely commented 
out. I don't know if this is incomplete work in progress, though I can see why 
one might want to do this  - the Classic toobar is far more plain than the Modern 
one.

So I guess, if we want to add this marble/blue background to the dialog titles, 
the question is: Should it just be done in the classic version of 
dialogOverlay.css or do we want to follow a pattern more similar to the Modern 
skin?

Comment 2

[Nikhil Bhatla (gone)]

assigning to myself

Comment 3

[Nikhil Bhatla (gone)]

Fixed.

Comment 4

[Andrew Thompson]

I note the PC Classic skin isn't using the marble effect, its using thr stripy 
effect that's behind the toolbar in M18 builds.

Are the skins supposed to diverge like this?

I actually prefer the marble?

Comment 5

[Nikhil Bhatla (gone)]

I prefer the marble look too.  [e-mail] recently changed them to the 
stripes, I believe.  You should email him and request the old look.

Comment 6

[Paul Wyskoczka]

Updated QA contact

Comment 7

[Zach Lipton [:zach]]

The lettering has been changed to black in 2000082409 OS9. Marking 
verified fixed.

P.S. I think that the marble is back now

Comment 8

[Patty Mac]

Fixed in all platforms
Mac (Build: 2000-09-06-04-M18)
Linux and Windows (Build: 2000-09-06-08-M18).