461944 - Selected event in unifinder is not highlighted in calendar view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- select an event in the unifinder

RESULT:
=======

- the selected event is not highlighted in the calendar view

EXPECTED RESULT:
================

- the selected event should be highlighted in the calendar view

REPRODUCIBLE:
=============

- always

Same behavior vice versa.

Last build without this issue: 20081022, first with this bug: 20081023.

Comment 1

[Martin Schröder [:mschroeder]]

Fallout from my last checkin... fix to come.

Comment 2

[Stefan Sitter [:ssitter]]

Bug 452381 was reopened because of this regression. See Bug 452381 comment #5 ff.

Comment 3

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 345262 [details] [diff] [review]
Patch v1

Looks good, r=philipp

Comment 5

[Martin Schröder [:mschroeder]]

Przemyslaw, please do not set the checkin-needed keyword for patches from people having checkin rights.

Comment 6

[Przemyslaw Bialik]

Sorry. Assuming the author would forget to add it can it be checked somewhere if he has them ?
or I will just use them on my own bugs...

Comment 7

[Martin Schröder [:mschroeder]]

Przemyslaw, there is no way to check who has those rights, so just set them on your own bugs.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/914b9beed0c3>

-> FIXED

Comment 8

[Przemyslaw Bialik]

-> VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081103 Lightning/1.0pre (build 20081103050206) Shredder/3.0b1pre

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Comment 10

[Markus Adrario [:Taraman]]

I'm still experiencing part of this in actual trunk builds.

in Multiweek- & Month-view, if you select a single event in unifinder, only the respective day gets highlighted, not the event.
if you select more than one, it works as expected.

Reopening this one for now, but I can also file a new bug if desired.
I'll have a look into this soon.

Comment 11

[Markus Adrario [:Taraman]]

First analysis showed that if a single event is selected in unifinder with month-view shown, relayout is triggered.
The relayout Method does not take into account selected items, so the box is not highlighted.
An easy fix would be:
  if (this.calendarView.mSelectedItems.indexOf(aItem) != -1) {
      box.setAttribute("selected", true);
  }
in the relayout method.

Since in Day- & MultiDay-view, the selection is even retained if switched to next day/week and back and in Month-view with this fix it is not, I'm not sure yet, if this is the way to do it.
I Will have to get more understanding of the selection-stuff in lightning.

Comment 12

[Markus Adrario [:Taraman]]

Just wondering:
do we really want to keep items selected, that are not in the current view?
This might en in deleting items you don't want to delete without confirmation and without seeing them disappear - thus unnoticed.
What is with items that are visible in the unifinder but not in a view?
One example:
1. go to week view
2. select an item in the unifinder
3. select another item, that is not in the current view.
4. change focus to the view by clicking the forward button
5. change back to the original week with the back button
6. selection in the unifinder is barely noticeable (at least with the current standard theme in ubuntu, windows7 is better)
7. hit delete

Outcome: both items are deleted, one may well go unnoticed.

Maybe we should rethink the way these selections work.
At least it should be more clear, which field has the focus and hitting delete should only delete the items in the focused view.
Any comments?

Comment 13

[Martin Schröder [:mschroeder]]

(In reply to Markus Adrario [:Taraman] from comment #10)
> Reopening this one for now, but I can also file a new bug if desired.
> I'll have a look into this soon.

I think filing a new bug report is more appropriate.

Comment 14

[Markus Adrario [:Taraman]]

done.

see Bug 723436