nativegen.py fails when running on PPC

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Brent Baker, Assigned: Steven Johnson)

Tracking

({flashplayer})

unspecified
PowerPC
Mac OS X
flashplayer
Bug Flags:
wanted-flashplayer10 +
flashplayer-triage +

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
File "../utils/nativegen.py", line 358, in __init__
      raise Error("Bad Abc Version")

Appears to be an endian issue.
Flags: wanted-flashplayer10+
Flags: flashplayer-triage+
(Reporter)

Updated

10 years ago
Assignee: nobody → stejohns
Status: NEW → ASSIGNED
(Assignee)

Comment 1

10 years ago
Created attachment 345178 [details] [diff] [review]
Patch

WARNING, I have not yet tested this patch on a PowerPC machine; but from description I suspect this fixes it (just need to specify little-endian in a couple of calls to unpack_from).
Attachment #345178 - Flags: review?(brbaker)
(Reporter)

Updated

10 years ago
Attachment #345178 - Flags: review?(brbaker) → review+
(Reporter)

Comment 2

10 years ago
The core/builtin.py script is working but I just found an issue in the shell/shell_toplevel.py script:

Traceback (most recent call last):
  File "../utils/nativegen.py", line 978, in <module>
    abcGenFor = Abc(data, abcScriptName)
  File "../utils/nativegen.py", line 360, in __init__
    self.parseCpool()
  File "../utils/nativegen.py", line 433, in parseCpool
    assert(int(ii) >= -2147483648 and int(ii) <= 2147483647)
AssertionError

Comment 3

10 years ago
just tested on ppc, seems fine.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.