Closed Bug 462023 Opened 16 years ago Closed 16 years ago

Mac OS X nsPluginFile::GetPluginInfo leaks in some error cases

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: jaas, Assigned: jaas)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 3 obsolete files)

fix v1.3
6.28 KB, patch
Details | Diff | Splinter Review 
Mac OS X nsPluginFile::GetPluginInfo (nsPluginsDirDarwin.cpp) leaks in some error cases, the leaks are marked with the following comment:

//XXX FIXME: past this point some (unlikely) error cases will leak memory
Attached patch fix v1.0 (obsolete) — — Splinter Review 

    
  

        Attachment #345217 -
        Flags: review?(mstange)

    
    

    
  
One thing I'm going to change is bzero -> memset.

        Attachment #345217 -
        Flags: review?(mstange) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.1 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #345217 -
        Attachment is obsolete: true

        Attachment #345317 -
        Flags: superreview?(jst)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #345317 -
        Attachment is obsolete: true

        Attachment #346531 -
        Flags: superreview?(jst)

        Attachment #345317 -
        Flags: superreview?(jst)

        Attachment #346531 -
        Flags: superreview?(jst)

        Attachment #346531 -
        Flags: superreview+

        Attachment #346531 -
        Flags: review+

    
  

        Attachment #346531 -
        Flags: approval1.9.1b2?

        Attachment #346531 -
        Flags: approval1.9.1b2? → approval1.9.1b2-

    
    

    
  
Comment on attachment 346531 [details] [diff] [review]
fix v1.2

Let's do this after beta2

    
    

    
  
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/7d90c98f97bf
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

    
    

    
  
this appears to have made its way onto the 1.9.1 branch already, somebody must have landed it after the branch and didn't comment here

    
    

    
  
I was wrong, this wasn't on the 1.9.1 branch before. It is now.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ab7ca6c812b7

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.3
        — 
          — Splinter Review
      

    


  
fix + bustage fix applied later

        Attachment #346531 -
        Attachment is obsolete: true

    
    

    
  
fixed1.9.1 keyword?

    
  
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: