462044 - Simplify some style rules in themes/*stripe/mozapps/help/help.css

Status: RESOLVED INVALID

(Toolkit :: Themes, defect)

Description

[Stefan [:stefanh]]

Attachment: Fix style rules

Now when we don't have any toolbarbutton in help.xul, we can get rid of some expensive style rules. I'll attach a patch for suite as well

Comment 1

[Stefan [:stefanh]]

Attachment: Screenshot of margin change effect on mac

You'll probably wonder why I change the margin on the back/fwd buttons dropmarker in pinstripe's help.css

-  margin-top: 3px;
+#help-back-button > .toolbarbutton-menubutton-dropmarker {
+  margin-top: 2px;

Comment 2

[Stefan [:stefanh]]

Attachment: Follow-up for suite

Comment 3

[Stefan [:stefanh]]

Oh, just to clarify (probably obvious, but anyway) - it looks like the screenshots when I've removed the suite theming.

Comment 4

[[e-mail]]

Comment on attachment 345157 [details] [diff] [review]
Follow-up for suite

>+toolbarbutton {
>   list-style-image: url("chrome://communicator/skin/icons/communicatoricons.png") !important;
>   list-style-image: inherit;
This makes no sense...

Comment 5

[[e-mail]]

(In reply to comment #1)
>You'll probably wonder why I change the margin on the back/fwd buttons
>dropmarker in pinstripe's help.css
> 
>>-  margin-top: 3px;
>>+#help-back-button > .toolbarbutton-menubutton-dropmarker {
>>+  margin-top: 2px;
1. What's the default margin-top on the dropmarker?
2. What happens with a margin-top of 1px?
3. What are the heights of the dropmarker and inner toolbarbutton?

(In reply to comment #4)
>(From update of attachment 345157 [details] [diff] [review])
>>+toolbarbutton {
>>   list-style-image: url("chrome://communicator/skin/icons/communicatoricons.png") !important;
>>   list-style-image: inherit;
>This makes no sense...
Neither does the subsequent -moz-image-region: inherit; in fact.

Comment 6

[[e-mail]]

Comment on attachment 345157 [details] [diff] [review]
Follow-up for suite

>-#HelpToolbar > toolbarbutton,
>-#HelpToolbar > toolbarbutton[type="menu-button"] > .toolbarbutton-menubutton-stack 
>+toolbarbutton,
>+toolbarbutton[type="menu-button"] > .toolbarbutton-menubutton-stack 
>   > .toolbarbutton-menubutton-button
BTW you might remove the trailing space while you're there ;-)

Comment 7

[Stefan [:stefanh]]

Actually, I need to do some more work because we're not overriding all pinstripe style rules in seamonkey... pinstripe/help uses it's own dropmarker and that is visible in seamonkey help.

Comment 8

[Stefan [:stefanh]]

This is invalid now since the help files have been moved to comm-central.