Closed Bug 462044 Opened 14 years ago Closed 6 years ago

Simplify some style rules in themes/*stripe/mozapps/help/help.css

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID
mozilla1.9.1b2

People

(Reporter: stefanh, Unassigned)

Details

Attachments

(3 files)

Attached patch Fix style rulesSplinter Review
Now when we don't have any toolbarbutton in help.xul, we can get rid of some expensive style rules. I'll attach a patch for suite as well
Attachment #345152 - Flags: review?(neil)
You'll probably wonder why I change the margin on the back/fwd buttons dropmarker in pinstripe's help.css

-  margin-top: 3px;
+#help-back-button > .toolbarbutton-menubutton-dropmarker {
+  margin-top: 2px;
Attachment #345157 - Flags: review?(neil)
Attachment #345156 - Attachment is patch: false
Attachment #345156 - Attachment mime type: text/plain → image/png
Oh, just to clarify (probably obvious, but anyway) - it looks like the screenshots when I've removed the suite theming.
Comment on attachment 345157 [details] [diff] [review]
Follow-up for suite

>+toolbarbutton {
>   list-style-image: url("chrome://communicator/skin/icons/communicatoricons.png") !important;
>   list-style-image: inherit;
This makes no sense...
(In reply to comment #1)
>You'll probably wonder why I change the margin on the back/fwd buttons
>dropmarker in pinstripe's help.css
> 
>>-  margin-top: 3px;
>>+#help-back-button > .toolbarbutton-menubutton-dropmarker {
>>+  margin-top: 2px;
1. What's the default margin-top on the dropmarker?
2. What happens with a margin-top of 1px?
3. What are the heights of the dropmarker and inner toolbarbutton?

(In reply to comment #4)
>(From update of attachment 345157 [details] [diff] [review])
>>+toolbarbutton {
>>   list-style-image: url("chrome://communicator/skin/icons/communicatoricons.png") !important;
>>   list-style-image: inherit;
>This makes no sense...
Neither does the subsequent -moz-image-region: inherit; in fact.
Comment on attachment 345157 [details] [diff] [review]
Follow-up for suite

>-#HelpToolbar > toolbarbutton,
>-#HelpToolbar > toolbarbutton[type="menu-button"] > .toolbarbutton-menubutton-stack 
>+toolbarbutton,
>+toolbarbutton[type="menu-button"] > .toolbarbutton-menubutton-stack 
>   > .toolbarbutton-menubutton-button
BTW you might remove the trailing space while you're there ;-)
Actually, I need to do some more work because we're not overriding all pinstripe style rules in seamonkey... pinstripe/help uses it's own dropmarker and that is visible in seamonkey help.
Status: ASSIGNED → NEW
Attachment #345152 - Flags: review?(neil)
Attachment #345157 - Flags: review?(neil)
This is invalid now since the help files have been moved to comm-central.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Assignee: stefanh → nobody
You need to log in before you can comment on or make changes to this bug.