462052 - all searches saved to system.log

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Michael Newton]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3 FirePHP/0.1.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3 FirePHP/0.1.2

Every search I make from the search bar is sent to syslog. I'm guessing for some that this would be a pretty big privacy concern, since system.log is world readable:

Oct 28 15:44:05 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: In data: "7"
Oct 28 15:44:05 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: Out data: "7"
Oct 28 15:44:05 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: In data: "79"
Oct 28 15:44:05 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: Out data: "79"
Oct 28 15:44:06 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: In data: "7960 logo"
Oct 28 15:44:06 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: Out data: "7960+logo"
Oct 28 15:44:07 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: In data: "7960 logo "
Oct 28 15:44:07 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: Out data: "7960+logo+"
Oct 28 15:44:10 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: In data: "7960 logo grey"
Oct 28 15:44:10 host [0x0-0x282282].org.mozilla.firefox[93888]: *** Search: getSubmission: Out data: "7960+logo+grey"

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Phil Ringnalda (:philor)]

If you go to about:config and filter for browser.search.log, is it set to true, and in bold with "user set" in the status column?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We print that output to stdout when you have browser.search.log set to true (default is false). The fact that it ends up in system.log is OS X's fault, I think.

Comment 3

[Michael Newton]

Yes, it is set to true in my profile. However, this data should be logged to a location within the user's profile directory, not to syslog.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

As I said, we log it to stdout. The fact that OSX takes stdout and puts it in system.log isn't something we can control.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(As far as I know, anyways.)