46207 - bugidtype=exclude breaks buglist.cgi in Bugzilla

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Hallvard B Furuseth]

buglist.cgi?bugidtype=exclude returns an error message
(e.g. if I use query.cgi's "[Exclude] bugs numbered: [...]").

To reproduce, visit the URL specified above.

Results: "Software error:
Internal error: Can't seem to handle '<code>bug_id</code>' and
'<code>noexact</code>' together at /opt/webtools/bugzilla/buglist.cgi line 613." 


[Enhancements - don't bother if they takes more than 5 additional minutes
when you are fixing this bug anyway]

- The URL would be more readable if a bug numbers could be separated by
spaces as well as commas.  That is, '+' instead of '%2C' in the URL.

- For that matter, what I'd really like is bugidtype=Add, not Include/Exclude.
That is, a set of bugIDs to be listed in addition to the ones specified by the
rest of the form. Or if nobody ever used bugidtype=exclude and that's why it's
(still) buggy, maybe you could just as well drop bugidtype and instead allow us
to say 'bug_id=2222/-2222/+2222' to include/exclude/add bug 2222 to the list.

Comment 1

[Dave Miller [:justdave]]

The "exclude bugs numbered [...]" thing tries to remap the query to a boolean 
chart in the processing code.  It tries to set the middle dropdown for the chart 
to "noexact".  "noexact" isn't a valid search method.  Changing the remapping 
code to use "nowords" instead correctly excludes the bug numbers listed.  (And 
since it works off of either space-delimited or comma-delimited words, has the 
desired side effect of letting you separate them with + if you want in a home-
brewed URL. :)

Your last suggestion there would probably be better off in its own bug report as 
a feature request.  Someone would have to get really creative to accomplish that, 
so it'll be more than a 5-minute fix.

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch to fix this bug

Comment 3

[Dave Miller [:justdave]]

This was a simple fix, and won't affect anything other than the bugidtype=exclude 
stuff.  And if it took everyone this long to discover it was broken to begin 
with...    I went ahead and checked this into the tree.  Note that this doesn't 
automatically fix the live bugzilla.  The mozilla.org folks have to update their 
copy before it'll fix the live one.

Comment 4

[Dave Miller [:justdave]]

Oops, I checked the wrong button there, that was supposed to be FIXED, not 
ASSIGNED :)

Comment 5

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 6

[Gervase Markham [:gerv]]

VERIFIED.

Gerv

Comment 7

[Gervase Markham [:gerv]]

VERIFIED.

Gerv

Comment 8

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product