Closed Bug 462121 Opened 13 years ago Closed 11 years ago

Reply function is broken. error identitiesCount is not defined

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: fredbezies, Assigned: jminta)

References

Details

(Keywords: regression, Whiteboard: [patchlove][regression part was backed out])

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b2pre) Gecko/20081029 Firefox/3.1b2pre
Build Identifier: 

Simple to see. Just click on a message and on reply.

I got this in error console :

Error: identitiesCount is not defined
Source File: chrome://messenger/content/mailCommands.js
Line: 78

Last modification : patch for bug 418490.

Reproducible: Always

Steps to Reproduce:
1.See details
2.
3.
Actual Results:  
No reply window

Expected Results:  
A reply window

Using up-to-date trunk code, built on Ubuntu Linux Intrepid Ibex AMD64.
Depends on: 418490
Keywords: regression
Blocks: 418490
No longer depends on: 418490
I have just backed out part of bug 418490. I will respin the nightlies once they complete.

http://hg.mozilla.org/comm-central/rev/a0c1355972f5
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
yikes, sorry, thx for backing out just part of bug 418490 - this works in the kill-rdf repo, and I remember fixing this in that repo a while ago, so I need to go see what I changed there...
Attached patch patch that should work (obsolete) — Splinter Review
this version of the changes to mailCommands.js seems to work fine for me, but double checking just to be sure I haven't screwed up anything again.
Assignee: nobody → bienvenu
Status: RESOLVED → REOPENED
Attachment #345326 - Flags: review?(bugzilla)
Resolution: FIXED → ---
Comment on attachment 345326 [details] [diff] [review]
patch that should work

oops, still need NewFolder
Attachment #345326 - Attachment is obsolete: true
Attachment #345326 - Flags: review?(bugzilla)
Attachment #345345 - Flags: review?(bugzilla) → review-
Comment on attachment 345345 [details] [diff] [review]
patch that just uses iterators, doesn't remove functions still used on trunk

+  var messages = [m for each (m in fixIterator(folder.getMessages(msgWindow)))];
+  var children = toXPCOMArray(messages, Components.interfaces.nsISupportsArray);

This is still wrong, toXPCOMArray doesn't exist, only toXPCOMIterator does.

However, now I read it again, doesn't toXPCOMArray actually make more sense for this function, as its returning an xpcom array, not an xpcom iterator?
ah, I see, empty junk is broken by this patch.

Yes, toXPCOMArray does seem like a better name - jminta, mind if I change iteratorUtils.jsm?
Version: unspecified → Trunk
Current status is:
regression fixed by backout,
looking for patch to re-apply the initial change.

Any update on comment 5 to comment 7?
Status: REOPENED → NEW
Whiteboard: [regression part was backed out]
Attached patch updated patchSplinter Review
This is an updated version of the patch. The toXPCOMArray stuff already got updated when the new folder-pane landed. See http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#1638
Attachment #393368 - Flags: review?(bienvenu)
Comment on attachment 393368 [details] [diff] [review]
updated patch

sorry for the delay...
Attachment #393368 - Flags: review?(bienvenu) → review+
Is this patch just waiting for check-in, or.?.
needs volunteer
is patch even still needed? 
 (code hasn't changed per http://mxr.mozilla.org/comm-central/source/mail/base/content/mailCommands.js#83 )
Assignee: bienvenu → nobody
Keywords: helpwanted
Summary: [Trunk]Reply function is broken. → Reply function is broken. error identitiesCount is not defined
Whiteboard: [regression part was backed out] → [patchlove][regression part was backed out]
Comment on attachment 345345 [details] [diff] [review]
patch that just uses iterators, doesn't remove functions still used on trunk

Patch is now obsolete (along with r-):

$ patch -p1 --dry-run < ~/Desktop/p462121-1.diff 
patching file mail/base/content/mailCommands.js
Hunk #1 FAILED at 69.
Hunk #2 FAILED at 498.
2 out of 2 hunks FAILED -- saving rejects to file mail/base/content/mailCommands.js.rej
Attachment #345345 - Attachment is obsolete: true
Comment on attachment 393368 [details] [diff] [review]
updated patch

Patch still applies!

$ patch -p1 --dry-run < ~/Desktop/p462121-2.diff 
patching file mail/base/content/mailCommands.js
Hunk #2 succeeded at 341 (offset 39 lines).
Setting checkin-needed, but please feel free to correct me if I'm wrong.
Keywords: checkin-needed
Assignee: nobody → jminta
Checked in: http://hg.mozilla.org/comm-central/rev/579f8b02ac29
Status: NEW → RESOLVED
Closed: 13 years ago11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.