462132 - [sk] Add Azet.sk mailto: protocol handler

Status: VERIFIED FIXED

(Mozilla Localizations :: sk / Slovak, defect)

Description

[Vlado Valastiak [:wladow]]

Attachment: add azet mailto handler

Azet.sk has just implemented mailto: protocol handler support for their webmail and because it's the most popular service in Slovakia we would like to add it to sk builds.

Name: Azet Mail
URL: http://emailnew.azet.sk/MailSend.phtml?url=%s

Contact person: Zuzana Chuda <[e-mail]>

Test suite tracker: http://spreadsheets.google.com/pub?key=pzJbUvwmY-2KB2zYYEOaNMg
(failing tests are being worked on)

Comment 1

[Vlado Valastiak [:wladow]]

After talking to stas regarding to test suite:
The last possibly failing test from ctalbert's test suite is the test 5. It's testing an invalid link mailto:[e-mail]?cc=[e-mail]?body=foo
Azet currently accepts TO and CC from the link and drops body param, what is a good implementation I think, even better than f.e. Gmail uses (Gmail uses '[e-mail]?body=foo' as a CC).

ctalbert's comment for this test: "Invalid mailto URL - this should not work. Ideally there should be some sort of error message caused by this URL. Very few implementations tend to create such a message though."

I don't know what RFC says, but azet's implementation sounds logically to me.

Comment 2

[Staś Małolepszy :stas]

Axel, Clint, what do you think about comment 1?

Vlado: does it do what would be logical when the URL is:
mailto:[e-mail]?body=foo?cc=[e-mail]
i.e. ignores CC and puts "foo" in the message body?

Or, what should actually happen if the URL is:
mailto:[e-mail]?cc=[e-mail]?body=foo&subject=bar

Comment 3

[Vlado Valastiak [:wladow]]

(In reply to comment #2)
> Axel, Clint, what do you think about comment 1?
> 
> Vlado: does it do what would be logical when the URL is:
> mailto:[e-mail]?body=foo?cc=[e-mail]
> i.e. ignores CC and puts "foo" in the message body?
yes

> 
> Or, what should actually happen if the URL is:
> mailto:[e-mail]?cc=[e-mail]?body=foo&subject=bar
azet is currently ignoring everything after the second '?' char, because that's the invalid part.

Comment 4

[cmtalbert]

(In reply to comment #3)
> (In reply to comment #2)
> > Axel, Clint, what do you think about comment 1?
> > 
> > Vlado: does it do what would be logical when the URL is:
> > mailto:[e-mail]?body=foo?cc=[e-mail]
> > i.e. ignores CC and puts "foo" in the message body?
> yes
> 
> > 
> > Or, what should actually happen if the URL is:
> > mailto:[e-mail]?cc=[e-mail]?body=foo&subject=bar
> azet is currently ignoring everything after the second '?' char, because that's
> the invalid part.

I think this implementation (to ignore everything after that second question mark) is a proper implementation.  If the second question mark is properly escaped, then it should *not* ignore the rest of the line.  Does it do that?

Comment 5

[Vlado Valastiak [:wladow]]

When escaped in above url, azet ignores body param and accepts subject. So I think this is the correct behaviour.

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 345264 [details] [diff] [review]
add azet mailto handler

This looks good then! :) Clint, thanks for the comment, Vlado, thanks for all the work verifying all test cases.

r=me. Please land this patch in hg. For CVS, I'm asking for approval1.9.0.5.

One more thing:

>+gecko.handlerService.schemes.mailto.2.name=Azet Mail
We won't be able to change the name, so just checking if "Azet Mail" is what you want.

Comment 7

[Vlado Valastiak [:wladow]]

(In reply to comment #6)
Thank you.

> >+gecko.handlerService.schemes.mailto.2.name=Azet Mail
> We won't be able to change the name, so just checking if "Azet Mail" is what
> you want.
Yes, that's what Azet folks proposed.

Comment 8

[Vlado Valastiak [:wladow]]

Pushed:
http://hg.mozilla.org/l10n-central/sk/rev/1d299ed9bff6

Comment 9

[Staś Małolepszy :stas]

Vlado, have you had a chance to verify this yet? Can we mark this bug as fixed?

Comment 10

[Vlado Valastiak [:wladow]]

Yes, works fine with hg builds, I'm just waiting for 
Pike's 'go' signal for landing to cvs, then I'll mark this fixed.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 345264 [details] [diff] [review]
add azet mailto handler

a=me for 3.0.5. Please land this with a check-in comment referencing this bug, stas' review and my approval. Something like "bug 462132, add azet.sk mailto protocol handler, r=stas, a=[e-mail]" would do.

Please use the fixed1.9.0.5 and verified1.9.0.5 keywords to track landing and testing.

Comment 12

[Vlado Valastiak [:wladow]]

Checked in: region.properties, rev. 1.9
-> fixed

Comment 13

[Vlado Valastiak [:wladow]]

Verified with 
Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.0.5pre) Gecko/2008112406 GranParadiso/3.0.5pre
and
Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b3pre) Gecko/20081126 Minefield/3.1b3pre