462141 - unreferenced local variable if !FS_ENCODE

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[timeless]

Attachment: make decls match consumers

fishsound_comments.c(303) : warning C4101: 'new_comment' : unreferenced local variable
fishsound_comments.c(328) : warning C4101: 'comment' : unreferenced local variable
fishsound_comments.c(353) : warning C4101: 'v_comment' : unreferenced local variable
fishsound_comments.c(380) : warning C4101: 'i' : unreferenced local variable
fishsound_comments.c(379) : warning C4101: 'comment' : unreferenced local variable

Comment 1

[Serge Gautherie (:sgautherie)]

Could you fix the other warnings too?

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090417 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9e06217fc471
 +http://hg.mozilla.org/comm-central/rev/...)

{
fishsound_comments.c(443) : warning C4018: '>' : signed/unsigned mismatch
fishsound_comments.c(480) : warning C4018: '>' : signed/unsigned mismatch
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
}

Comment 2

[cajbir (:cajbir)]

Attachment: add README_MOZILLA, and patch file, update to tip

Add README_MOZILLA entry, update.sh and include patch file. Also raised as annodex ticket 497:

https://trac.annodex.net/ticket/497

Comment 3

[cajbir (:cajbir)]

Pushed to mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/890e35aa6a46

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ba7c6a55181d