unreferenced local variable if !FS_ENCODE

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: timeless, Assigned: cajbir)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Created attachment 345274 [details] [diff] [review]
make decls match consumers

fishsound_comments.c(303) : warning C4101: 'new_comment' : unreferenced local variable
fishsound_comments.c(328) : warning C4101: 'comment' : unreferenced local variable
fishsound_comments.c(353) : warning C4101: 'v_comment' : unreferenced local variable
fishsound_comments.c(380) : warning C4101: 'i' : unreferenced local variable
fishsound_comments.c(379) : warning C4101: 'comment' : unreferenced local variable
Attachment #345274 - Flags: review?(chris.double)
Could you fix the other warnings too?

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090417 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9e06217fc471
 +http://hg.mozilla.org/comm-central/rev/...)

{
fishsound_comments.c(443) : warning C4018: '>' : signed/unsigned mismatch
fishsound_comments.c(480) : warning C4018: '>' : signed/unsigned mismatch
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
fishsound_comments.c(622) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data
}
Blocks: 90906
(Assignee)

Comment 2

9 years ago
Created attachment 403179 [details] [diff] [review]
add README_MOZILLA, and patch file, update to tip

Add README_MOZILLA entry, update.sh and include patch file. Also raised as annodex ticket 497:

https://trac.annodex.net/ticket/497
Assignee: timeless → chris.double
Attachment #345274 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #403179 - Flags: review?
Attachment #345274 - Flags: review?(chris.double)
(Assignee)

Updated

9 years ago
Attachment #403179 - Flags: review? → review?(kinetik)
Attachment #403179 - Flags: review?(kinetik) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

9 years ago
Pushed to mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/890e35aa6a46
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.