462184 - TM: Make INCLUDE_VERSBOSE_OUTPUT actually work in non-debug buildsx

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Patch attached.

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 345315 [details] [diff] [review]
Like so

>diff --git a/js/src/jsopcode.cpp b/js/src/jsopcode.cpp
>--- a/js/src/jsopcode.cpp
>+++ b/js/src/jsopcode.cpp
>@@ -99,27 +99,25 @@ uintN js_NumCodeSpecs = JS_ARRAY_LENGTH(
>  */
> static const char *CodeToken[] = {
> #define OPDEF(op,val,name,token,length,nuses,ndefs,prec,format) \
>     token,
> #include "jsopcode.tbl"
> #undef OPDEF
> };
> 
>-#ifdef DEBUG
>-/*
>- * Array of JS bytecode names used by DEBUG-only js_Disassemble.
>+/*
>+ * Array of JS bytecode names.
>  */
> const char *js_CodeName[] = {
> #define OPDEF(op,val,name,token,length,nuses,ndefs,prec,format) \
>     name,
> #include "jsopcode.tbl"
> #undef OPDEF
> };
>-#endif

We took these out to save some space. Can you test #if defined DEBUG || defind INCLUDE_VERBOSE_OUTPUT?

INCLUDE_VERBOSE_OUTPUT is too generic a name. How about JS_JIT_SPEW? I'm not kidding :-P.

>+#ifdef DEBUG
>+#define INCLUDE_VERBOSE_OUTPUT
>+#endif

Want #if defined DEBUG && !defined JS_JIT_SPEW to avoid whinage if someone defines via -D (which gives the macro "1" as its value, which is not the same as a defined to empty body macro).

/be

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to comments

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 345417 [details] [diff] [review]
Updated to comments

Looks good to me, trust it works built both ways (DEBUG and JS_JIT_SPEW). Thanks,

/be

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed changeset 9994733fb845.