462204 - Don't try to cancel a not existant timer in nsPlacesDBFlush

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

in onBeginUpdateBatch sometimes we try to cancel a not existant this._timer

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

Actually this was mostly due to my build bustage, however it's safer restoring the timer before.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 345354 [details] [diff] [review]
patch

>+    // Restore our timer
>+    this._timer = this._newTimer();
>+    // We need to sync now
>     this._syncTables(["places", "historyvisits"]);
nit: newline between these two bits please

r=sdwilsh

Comment 3

[Marco Bonardo [:mak]]

addressed comment

http://hg.mozilla.org/mozilla-central/rev/053d94c29c51

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv