Closed Bug 462206 Opened 11 years ago Closed 11 years ago

finalize statements in nsPlacesDBFlush

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

in syncTables we should finalize statements, or we could hit problems
Blocks: 462214
Attached patch patchSplinter Review
Attachment #345356 - Flags: review?(sdwilsh)
Comment on attachment 345356 [details] [diff] [review]
patch

My thinking was a bit wrong about this - nothing bad will happen, but we should do it still.  So I would drop the comment altogether.

>+    // Finalize statements, otherwise we could get in trouble
>+    for (let i = 0; i < statements.length; i++)
>+      statements[i].finalize();
Just do statements.forEach(function(stmt) stmt.finalize());

r=sdwilsh with those changes
Attachment #345356 - Flags: review?(sdwilsh) → review+
addressed comment

http://hg.mozilla.org/mozilla-central/rev/03288ea8c289
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.