Closed
Bug 462215
Opened 16 years ago
Closed 16 years ago
javascript autoconf busted on windows mobile
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
References
()
Details
Attachments
(1 file)
3.16 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
after running a build using the windows mobile patch queue, I noticed that that OS_ARCH, OS_TARGET are not set properly. To match what mozilla config does: OS_TARGET=WINCE OS_ARCH=WINCE instead, we have: OS_TARGET=WINNT OS_ARCH=WINNT
Assignee | ||
Comment 1•16 years ago
|
||
The change to Makefile.in is required because when linking, we can not restart the link due to the use of the tool wrapper we are using on windows mobile. restarting the tool seems to not pass the correct LIBPATH. We probably can revert this change if we can get rid of the tool wrappers. The second part are changes to configure.in: 1) we do not want to rebuild the windows shunt library and toolset. Windows mobile developers, if building js outside of mozilla, have a prereq to set these tools and libraries up themselves. Ideally, at some point we will not need the shunt of the specialized tool wrappers. 2) CROSS_COMPILE is not being set, but $cross_compiling is set. This is similar to what nsprpub/configure.in is doing. 3) defining WINCE
Attachment #345370 -
Flags: review?(ted.mielczarek)
Comment 2•16 years ago
|
||
Comment on attachment 345370 [details] [diff] [review] patch v.1 +# -GL is not supported on windows mobile while we are using the arm-wince-link command +MODULE_OPTIMIZE_FLAGS = -O2 +else MODULE_OPTIMIZE_FLAGS = -O2 -GL endif endif +endif Can you stick some comments on the end of these endifs so we know what they correspond to? 3 levels deep stats to get tricky to keep track of.
Attachment #345370 -
Flags: review?(ted.mielczarek) → review+
Comment 3•16 years ago
|
||
Comment on attachment 345370 [details] [diff] [review] patch v.1 + +if test "$cross_compiling" = "yes"; then + CROSS_COMPILE=1 +else + CROSS_COMPILE= +fi Isn't CROSS_COMPILE tested up at line 166 ("Default to MSVC for win32")? Will setting it down here be too late?
Assignee | ||
Comment 4•16 years ago
|
||
it needs to be checked after line 197 (where we set it)
Assignee | ||
Updated•16 years ago
|
Summary: javscript autoconf busted on widows mobile → javascript autoconf busted on windows mobile
Assignee | ||
Comment 5•16 years ago
|
||
pushed 56e84df2b796. fwiw, i also filed 462427 which will clean up the cross_compile support in mozilla's build system.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•