Closed Bug 46224 Opened 24 years ago Closed 24 years ago

[FIX]Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20

Categories

(Core :: Layout: Form Controls, defect, P3)

x86
Windows 98
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: MatsPalmgren_bugz, Assigned: rods)

References

()

Details

(Keywords: testcase, Whiteboard: [nsbeta3+]Fix in hand; request engineer feedback-ckritzer;)

Attachments

(1 file)

When the value for the SIZE attribute can't be interpreted as a non-negative
number it currently defaults to SIZE=0, which results in a useless text field.
I think it should default to SIZE=20, like in IE5.

I will attach a testcase showing <INPUT type="TEXT"> with various SIZE values
and a table of results for IE5, NS 4.72 and M17 2000-07-20-08 (Windows 98 SE).

(This bug is not about how many characters that actually fits)
Attached file Testcase
Forgot the URL, http://www.gulasidorna.se (The Swedish "Yellow Pages")
Status: NEW → ASSIGNED
Target Milestone: --- → M22
Triaging Rods bug list.
This code:

  if (*aSize < 1) {
    *aSize = 1;
  }

fixes it and it now will mimic NavQuirks. If we want, we could very easily mimic 
IE in Standard mode. any votes?
Keywords: 4xp, nsbeta3
Summary: Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20 → [FIX]Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20
Whiteboard: Fix in hand
Target Milestone: M22 → M17
86% market share bla bla bla, I vote for IE compatibility in *all* modes.
After all, SIZE=20 is a much more reasonable fallback value than SIZE=1.
Marking nsbeta3+

Ideally we would use 1 in NavQuirks, 20 in standard mode. Up to rods based on 
difficulty and time to implement this.

Can set correct size if this behavior is inadequate.
Whiteboard: Fix in hand → [nsbeta3+]Fix in hand
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
This is now setting to size=1 on:
- LinuxRH62 2000-09-08-08-M18 Commercial
- Win98     2000-09-08-08-M18 Mozilla
- MacOS86   2000-09-07-04-M18 Commercial

Is this the correct behaviour?
Whiteboard: [nsbeta3+]Fix in hand → [nsbeta3+]Fix in hand; request engineer feedback-ckritzer;
I am not sure what the "correct" behavior is, but we match 4.x now.
lol - fair enough.
Marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98     2000-09-13-08-M18 Mozilla
- MacOS86   2000-09-13-04-M18 Commercial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: