[FIX]Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20

VERIFIED FIXED in M17

Status

()

Core
Layout: Form Controls
P3
minor
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: mats, Assigned: rods (gone))

Tracking

({testcase})

Trunk
x86
Windows 98
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+]Fix in hand; request engineer feedback-ckritzer;, URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
When the value for the SIZE attribute can't be interpreted as a non-negative
number it currently defaults to SIZE=0, which results in a useless text field.
I think it should default to SIZE=20, like in IE5.

I will attach a testcase showing <INPUT type="TEXT"> with various SIZE values
and a table of results for IE5, NS 4.72 and M17 2000-07-20-08 (Windows 98 SE).

(This bug is not about how many characters that actually fits)
(Reporter)

Comment 1

18 years ago
Created attachment 11789 [details]
Testcase
(Reporter)

Comment 2

18 years ago
Forgot the URL, http://www.gulasidorna.se (The Swedish "Yellow Pages")
Keywords: testcase

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → M22
Triaging Rods bug list.
(Assignee)

Comment 4

18 years ago
This code:

  if (*aSize < 1) {
    *aSize = 1;
  }

fixes it and it now will mimic NavQuirks. If we want, we could very easily mimic 
IE in Standard mode. any votes?
Keywords: 4xp, nsbeta3
Summary: Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20 → [FIX]Bad SIZE for <INPUT type="TEXT"> should default to SIZE=20
Whiteboard: Fix in hand
Target Milestone: M22 → M17
(Reporter)

Comment 5

18 years ago
86% market share bla bla bla, I vote for IE compatibility in *all* modes.
After all, SIZE=20 is a much more reasonable fallback value than SIZE=1.
Marking nsbeta3+

Ideally we would use 1 in NavQuirks, 20 in standard mode. Up to rods based on 
difficulty and time to implement this.

Can set correct size if this behavior is inadequate.
Whiteboard: Fix in hand → [nsbeta3+]Fix in hand
(Assignee)

Comment 7

18 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 8

18 years ago
This is now setting to size=1 on:
- LinuxRH62 2000-09-08-08-M18 Commercial
- Win98     2000-09-08-08-M18 Mozilla
- MacOS86   2000-09-07-04-M18 Commercial

Is this the correct behaviour?
Whiteboard: [nsbeta3+]Fix in hand → [nsbeta3+]Fix in hand; request engineer feedback-ckritzer;
(Assignee)

Comment 9

18 years ago
I am not sure what the "correct" behavior is, but we match 4.x now.

Comment 10

18 years ago
lol - fair enough.
Marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98     2000-09-13-08-M18 Mozilla
- MacOS86   2000-09-13-04-M18 Commercial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.