Closed Bug 462271 Opened 15 years ago Closed 15 years ago

Sisyphus - JavaScript Tests - support autoconf built spidermonkey

Categories

(Testing Graveyard :: Sisyphus, enhancement)

Product:
Testing Graveyard
Component:
Sisyphus
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
8.19 KB, patch
cbook
: review+
Details | Diff | Splinter Review 
bug 97954 removed Makefile.ref and replaced it with an autoconf based configure and build system. This patch switches between the Makefile.ref and autoconf approaches depending on the existence of the js/src/Makefile.ref file. Note the fix for the underlying bug due to Mac 8.11.1's failure to return non zero exit codes for the command |which|.
Flags: in-testsuite-
Flags: in-litmus-
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #345410 -
        Flags: review?(cbook)

    
    

    
  
Comment on attachment 345410 [details] [diff] [review]
patch

looks and works good ! Many thanks Bob !

        Attachment #345410 -
        Flags: review?(cbook) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  
Tomcat, try this one out please.

        Attachment #345410 -
        Attachment is obsolete: true

        Attachment #345623 -
        Flags: review?(cbook)

        Attachment #345623 -
        Flags: review?(cbook) → review+

    
    

    
  
Comment on attachment 345623 [details] [diff] [review]
patch v2

r+ my testbuilds failed without the  patch and pass with the patch applied !

Thanks Bob !

    
    

    
  
/cvsroot/mozilla/testing/sisyphus/bin/build.sh,v  <--  build.sh
new revision: 1.11; previous revision: 1.10
done
Checking in clobber.sh;
/cvsroot/mozilla/testing/sisyphus/bin/clobber.sh,v  <--  clobber.sh
new revision: 1.4; previous revision: 1.3
done
Checking in library.sh;
/cvsroot/mozilla/testing/sisyphus/bin/library.sh,v  <--  library.sh
new revision: 1.13; previous revision: 1.12
done
Checking in tester.sh;
/cvsroot/mozilla/testing/sisyphus/bin/tester.sh,v  <--  tester.sh
new revision: 1.11; previous revision: 1.10
done

http://hg.mozilla.org/mozilla-central/rev/8c3fd1c53059¡
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.
Component: Testing → Sisyphus
Flags: in-litmus-
Product: Core → Testing
QA Contact: testing → sisyphus

    
  
Product: Testing → Testing Graveyard

          You need to log in
          before you can comment on or make changes to this bug.