"Assertion failure: pn->pn_op == JSOP_CALL || pn->pn_op == JSOP_EVAL" with apply as LHS

RESOLVED FIXED

Status

()

defect
--
critical
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: jruderman, Assigned: gal)

Tracking

(Blocks 1 bug, {assertion, regression, testcase})

Trunk
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
1.53 KB, patch
brendan
: review+
Details | Diff | Splinter Review
Reporter

Description

11 years ago
[].apply() = 1;

Assertion failure: pn->pn_op == JSOP_CALL || pn->pn_op == JSOP_EVAL, at jsparse.cpp:1684

Tracemonkey branch, but does not require -j.  Regression from bug 462209?
Assignee

Comment 1

11 years ago
Posted patch patch (obsolete) — Splinter Review
Assignee: general → gal
Status: NEW → ASSIGNED
Attachment #345434 - Flags: review?
Assignee

Updated

11 years ago
Attachment #345434 - Flags: review? → review?(jruderman)
Assignee

Comment 2

11 years ago
Comment on attachment 345434 [details] [diff] [review]
patch

Forgot to add the new JSOP_APPLY case to the assert list. Jesse, if you don't feel confident review this hand it to mrbkap or brendan.
Andreas, search for other instances of the same assertion, I think we have it repeated several times.
Assignee

Comment 4

11 years ago
Ok, will do.
Assignee

Updated

11 years ago
Attachment #345434 - Flags: review?(jruderman)
Assignee

Comment 5

11 years ago
Posted patch v2Splinter Review
Not sure what the 2nd cases does. Blake?
Attachment #345434 - Attachment is obsolete: true
Attachment #345436 - Flags: review?(mrbkap)
Attachment #345436 - Flags: review?(mrbkap) → review+
Assignee

Comment 6

11 years ago
http://hg.mozilla.org/tracemonkey/rev/b513ecb09631
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

Comment 7

11 years ago
http://hg.mozilla.org/mozilla-central/rev/37b3fdbb0f07
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-462292.js,v  <--  regress-462292.js
initial revision: 1.1
Flags: in-testsuite+
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.