462326 - Thunderbird with Lightning leaks on Shutdown.

Status: RESOLVED FIXED

(Calendar :: General, defect, P1)

Description

[Mark Banner (:standard8)]

Attachment: Leak Log

Thunderbird is just about to have leak and bloat boxes on trunk. At the moment these will definitely go orange due to reference count shutdown leaks within Lightning. These do not occur when just Thunderbird is running.

As when we integrate Thunderbird + Lightning on the builds, this will make the tinderboxes go orange, I think we should try and fix these.

These occur with a basic profile (no calendars defined on startup), and without actually opening a calendar tab.

More information on the profile, and how to run the tests can be found here:

https://wiki.mozilla.org/MailNews:Memory_Bloat_and_Leak_Tests

We may need to investigate trace-malloc leaks as well, but seeing as they will be affected by these, then I suggest we clear these off first.

There may be some related bugs, e.g. Bug 426973 - Sunbird leaking on shutdown, but I wanted one specifically for tracking what would block Lightning integrating with TB.

If you need help investigating, let me know.

Comment 1

[Stefan Sitter [:ssitter]]

I think Bug 457024 re-added some leaks to prevent the shutdown crash.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> I think Bug 457024 re-added some leaks to prevent the shutdown crash.

That was proposed at one time, but the patch that went in didn't add leaks (it would have probably reduced them).

Comment 3

[Daniel Boelzle [:dbo]]

Right, bug 457024 hasn't added leaks.
I'll have a look at my bloat and XPC_SHUTDOWN_HEAP_DUMP logs, too.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

This will turn Tinderbox orange; plussing.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

the mozStorage* leaks point to either the storage calendar or the calendar manager. It might be worth removing any storage calendars (and disabling auto-creating the home calendar), to see what changes.
It might be that the problem is that the two keep each other alive, so be careful with blaming one or the other.

Comment 6

[Daniel Boelzle [:dbo]]

Attachment: xpc shutdown heap

Comment 7

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Seems to be caused by cyclic references via wrapped js objects. This patch removes the init-once references from calUtils.js. We could use a shutdown-observer like I added in calUtils.jsm once we clean up calUtils.js into calUtils.jsm.

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 350313 [details] [diff] [review]
fix - v1

> cal.LOG("XXXXXXX observing: "...
I'll remove that, of course.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 350313 [details] [diff] [review]
fix - v1

Looks good to me, if you like go ahead and migrate the accessors to calUtils.jsm?

Comment 10

[Daniel Boelzle [:dbo]]

> (From update of attachment 350313 [details] [diff] [review])
> Looks good to me, if you like go ahead and migrate the accessors to
> calUtils.jsm?
I leave that to another bug; I assume it'll be a lot of changes.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/27ee6082367d>

-> FIXED, my bloat log doesn't show them any longer.

Mark, could you please verify (in your setup) whether this is OK now?

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".