Closed
Bug 462350
Opened 16 years ago
Closed 16 years ago
Refactor and rename test_bug428479.html to test_aria_role_equation.html
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file)
4.70 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
Refactor to use common files and functions, and rename to a more speaking name.
Assignee | ||
Comment 1•16 years ago
|
||
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #345492 -
Flags: review?(surkov.alexander)
Comment 2•16 years ago
|
||
Comment on attachment 345492 [details] [diff] [review] Patch > <script type="application/javascript"> > function testThis(aID, aAcc) > { >- is(aAcc.finalRole, >- Components.interfaces.nsIAccessibleRole.ROLE_FLAT_EQUATION, >+ is(aAcc.finalRole, ROLE_FLAT_EQUATION, > "Wrong role for " + aID +"!"); > is(aAcc.name, "x^2 + y^2 + z^2", "Wrong name for " + aID + "!"); > } > > function doTest() > { >+ var imgEqAcc = getAccessible("img_eq"); I would suggest to move getAccessible to testThis, so that you will call testThis("img_eq"); testThis("txt_eq");
Attachment #345492 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Pushed with Surkov's comment addressed in changeset: http://hg.mozilla.org/mozilla-central/rev/7c03312dd190
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•