462356 - Build fails on mac in js/src/configure.in with error: Library requirements (glib-2.0 >= 1.3.7 gobject-2.0) not met;

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Simon Montagu :smontagu]

Attachment: Patch

Putting the test inside a test for MOZ_ENABLE_GTK2 fixes it for me.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 345496 [details] [diff] [review]
Patch

I'd like jimb to look at this.

Comment 2

[Jim Blandy :jimb]

Actually, the check that's failing is trying to produce values for the make variables GLIB_CFLAGS, GLIB_LIBS, and GLIB_GMODULE_LIBS --- which are not, in fact, used anywhere in js/src at all.  So we can just drop that section of the configure script altogether, I think.

Comment 3

[Jim Blandy :jimb]

Actually, that's not true: elf-dynstr-gc.c needs it.  Hmm.

Comment 4

[Jim Blandy :jimb]

Comment on attachment 345496 [details] [diff] [review]
Patch

We need to be able to build elf-dynstr-gc whether or not GTK2 is enabled.  Let me see what I can do about elf-dynstr-gc.

Comment 5

[Simon Montagu :smontagu]

So can we just do the same as http://mxr.mozilla.org/mozilla-central/source/configure.in#7271 ?

Comment 6

[Jim Blandy :jimb]

But js/src doesn't need elf-dynstr-gc.  Excision time.

Comment 7

[Jim Blandy :jimb]

Attachment: Bug 462356: js/src doesn't need elf-dynstr-gc; drop source and build info. [Checkin: Comment 11]

Here's the first of two patches to drop elf-dynstr-gc and glib from js/src.  I'll r? it once the Try server likes it.

Comment 8

[Jim Blandy :jimb]

Attachment: Bug 462356: js/src doesn't need glib. Drop glib-related configury. [Checkin: Comment 12]

Second of two patches, this one deleting the glib configure tests.  Will r? when Try server likes it.

Comment 10

[Jim Blandy :jimb]

Comment on attachment 345554 [details] [diff] [review]
Bug 462356: js/src doesn't need glib.  Drop glib-related configury.
[Checkin: Comment 12]


The Try server likes these two.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 345552 [details] [diff] [review]
Bug 462356: js/src doesn't need elf-dynstr-gc; drop source and build info.
[Checkin: Comment 11]

http://hg.mozilla.org/mozilla-central/rev/5c46ab09eac8

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 345554 [details] [diff] [review]
Bug 462356: js/src doesn't need glib.  Drop glib-related configury.
[Checkin: Comment 12]


http://hg.mozilla.org/mozilla-central/rev/e5185b19a790

Comment 13

[Simon Montagu :smontagu]

Unpatched trunk now builds for me with no errors. VERIFIED and thanks for the fix.