Closed
Bug 462361
Opened 16 years ago
Closed 14 years ago
Remove support for building with Cygwin
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: Mitch)
Details
Attachments
(1 file)
55.07 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
We should drop support for building with cygwin. This means a lot of complexity related to cygwin-wrapper and perl and line endings can disappear.
Reporter | ||
Updated•15 years ago
|
Assignee: benjamin → nobody
Updated•15 years ago
|
Severity: normal → trivial
Flags: in-testsuite-
Version: unspecified → Trunk
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → mitchell.field
Status: NEW → ASSIGNED
Assignee | ||
Updated•14 years ago
|
Summary: Remove support for building with cygwin → Remove support for building with Cygwin
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #506191 -
Flags: review?(khuey)
Comment on attachment 506191 [details] [diff] [review] Patch v1 > case $target_os in >- os2*|msvc*|mks*|cygwin*|mingw*|darwin*|wince*|winmo*|beos*) >+ beos*|darwin*|mingw*|os2*|wince*|winmo*) Remove the beos from this line since you're here anyways. I didn't look at the js/src bits, assuming they're the same.
Attachment #506191 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Comment on attachment 506191 [details] [diff] [review] > Patch v1 > > > case $target_os in > >- os2*|msvc*|mks*|cygwin*|mingw*|darwin*|wince*|winmo*|beos*) > >+ beos*|darwin*|mingw*|os2*|wince*|winmo*) > > Remove the beos from this line since you're here anyways. > > I didn't look at the js/src bits, assuming they're the same. There are a lot of BeOS-related things lying around. https://mxr.mozilla.org/mozilla-central/search?string=beos I thought it'd make more sense to keep within this bug's scope and target BeOS in another bug report.
I agree in general, but you're touching that exact line anyways :-/
Comment 5•14 years ago
|
||
Fwiw, either way, WinCE is in the same case too: bug 614720...
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/261f1a85206a
http://hg.mozilla.org/mozilla-central/rev/261f1a85206a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•