462432 - Leak mAsyncExecutionMutex

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

We currently leak mAsyncExecutionMutex added in bug 460635.  I missed this in my review.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 don't leak the async execution mutex, also verify its existence at init

This corrects the leak.  nsAutoLock is an unusual mutex abstraction... I also neglected to NS_ENSURE_TRUE as is done for the other mutexes, so we do that too now.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init

r=sdwilsh

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Marking for check-in.  This passed linux/linux talos/OS X try-server; windows had unrelated bustage and windows talos failed to run.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init

Limiting the number of checkins required before we can finish this beta. We'll get this after.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init

a191=beltzner

Comment 7

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/5db9c30a41e0