Closed Bug 462434 Opened 13 years ago Closed 13 years ago

Transaction semantics are bad

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file)

v1.0
1.55 KB, patch
asuth
: review+
Details | Diff | Splinter Review 
How it currently works, we end up breaking assumptions that mozStorageTransaction holds, causing badness.
Attached patch v1.0 — — Splinter Review
Attachment #345579 - Flags: review?(bugmail)
Comment on attachment 345579 [details] [diff] [review]
v1.0

Looks good.  mozStorageTransaction should no longer be misled about what is happening with transactions, and mozStorageConnection's understanding of whether one is active should be consistent with the underlying sqlite state.
Attachment #345579 - Flags: review?(bugmail) → review+
Whiteboard: [has patch][has review][can land]
http://hg.mozilla.org/mozilla-central/rev/f7e6ad1f2be3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
You need to log in before you can comment on or make changes to this bug.