Closed Bug 462446 Opened 11 years ago Closed 11 years ago

Optimize panning

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: pavlov, Unassigned)

References

Details

Attachments

(1 obsolete file)

Right now when we end a pan, we redraw the entire canvas.  Rather than doing that, let us blit and then repaint the changed area.

There seem to be a couple of rounding bugs in here, but otherwise it seems to work fine.
Flags: blocking-fennec1.0+
Attached patch fix (obsolete) — Splinter Review
this greatly speeds up panning, although it has a couple of bugs that need to be worked out.  there are a few rounding bugs I could use some help finding as well as a bug where it looks like the full height doesn't always get redrawn, or things are off by a couple pixels.

the other bug is that since we suppress paints while panning, we need to keep track of them now in a dirty region and repaint them when we're done panning in addition to the other parts we repaint
Attachment #345905 - Flags: superreview?(vladimir)
Attachment #345905 - Flags: review?(gavin.sharp)
Depends on: 462425
stuart: have kinds of changes landed from mb-cleanup? can we close this one?
ah yeah, this has landed as part of mb-cleanup
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #345905 - Attachment is obsolete: true
Attachment #345905 - Flags: superreview?(vladimir)
Attachment #345905 - Flags: review?(gavin.sharp)
verified FIXED (using panning+tilecaching check+ large pages) on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.