462500 - value, alt, and title values won't be translated when interactive translation is on

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[David Tenser [:djst]]

Attachment: Some strings aren't used

As the attached screenshot is showing, the string "Edit language table" is actually already translated into fy-NL as "Bewurkje taaltabel", but the button still says "Edit language table".

In other words, the string for that button text is not being localized for some reason. There are other examples of this, e.g. buttons for "Add", "Search", etc. All on that same page.

Comment 1

[E. Cooper [:ecooper]]

It seems like this only occurs on buttons when the interactive UI translation mode is on.

Comment 2

[E. Cooper [:ecooper]]

After a bit of investigation, I found that strings inside alt, title, or value attributes (<input type="submit" value="{tr}Save{/tr}"/>) won't be translated unless interactive param is used in the tr block when the interactive translation mode is on. 

We should be able to fix this with some sed magic.

Comment 3

[E. Cooper [:ecooper]]

I should emphasize that this only occurs when interactive translation mode is on, and is typically only visible on buttons.

Comment 4

[E. Cooper [:ecooper]]

Attachment: Add a regex to turn off interactive mode for {tr} blocks within value attributes

This will only "fix" buttons. alt and title attributes will remain untranslated for the time being as a different approach needs to be taken with them...most likely changing the {tr} blocks in the templates.

Comment 5

[E. Cooper [:ecooper]]

r23472/r23473

It can be verified using David's example, or visiting any page with 'submit buttons' while interactive translation mode is on.

We should make extra sure no regressions are caused by this. Thankfully, I haven't seen any locally.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

This verifies it, no?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Oh, and URL I used was https://support-stage.mozilla.org/tiki-edit_languages.php?locale=fy-NL, because URLs to reproduce and verify bugs are immensely helpful :-)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED

Comment 9

[Louis-Philippe Huberdeau]

Value was already resolved, added title and alt.