462528 - Crash when opening mail with vcard attach [@ uStrLen - fakeCString]

Status: RESOLVED DUPLICATE of bug 473924

(MailNews Core :: Backend, defect)

Description

[Arvid Herfjord]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: version 2.0.0.17 (20080914)

Opening this mail (http://www.herfjord.no/temp/2008-10-30_09-57 Re-Emails.eml) crashes Thunderbird. Sometimes immediately, sometimes it won't display any more mails and eventually crashes.

The last part of the mail has content-type: text/x-vcard. When changing that to text/plain everything is OK.

Reproducible: Always

Steps to Reproduce:
1. Simply open the mail with Thunderbird, including last nightly build.
2.
3.
Actual Results:  
Thunderbird crashes or stops working.

Expected Results:  
Shown the mail contents.

Same thing happens with different config on another machine. Seems all mails from this particular sender has this problem. Outlook and OE shows the mail as expected.

Comment 1

[Arvid Herfjord]

Attachment: Testcase: The mail that crashes TB

Comment 2

[Nikolay Shopik]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081031 Shredder/3.0b1pre
crash
bp-cfea18b0-a78f-11dd-a141-001321b13766
bp-eec531c2-a78f-11dd-b79b-001cc4e2bf68
bp-d474252e-a78f-11dd-a328-001321b13766

Comment 3

[Mark Banner (:standard8)]

Unfortunately none of Nikolay's crash ids are useful. I did get one on Linux earlier with today's trunk:

bp-53f95d99-a766-11dd-a5ed-001cc45a2c28

This is useful and points to the source of the problem, which I'm not surprised at the details of text/x-vcard in comment 0. I'll take this and see if I can find the problem.

Comment 4

[Nikolay Shopik]

I wonder why my crashes not point to problem

Comment 5

[timeless]

we're probably missing symbols for windows builds

http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/src/nsVCardObj.cpp?mark=1325,1330,1332,1335,1317#1313

i believe on linux uStrLen was inlined and the problem is that the pointer was null.

mark: while fixing it, please handle malloc failure too.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to comment #3)
> Unfortunately none of Nikolay's crash ids are useful. I did get one on Linux
> earlier with today's trunk:
> 
> bp-53f95d99-a766-11dd-a5ed-001cc45a2c28
> 
> This is useful and points to the source of the problem, which I'm not surprised
> at the details of text/x-vcard in comment 0. I'll take this and see if I can
> find the problem.

fakeCString	 nsVCardObj.cpp:1317
nsMsgVCardService::FakeCString	nsMsgVCardService.cpp:70
MimeInlineTextVCard_parse_eof	mimevcrd.cpp:418
MimeMultipart_close_child	mimemult.cpp:593
MimeMultipart_parse_line	mimemult.cpp:185
convert_and_send_buffer	mimebuf.cpp:184
mime_LineBuffer	mimebuf.cpp:272
MimeObject_parse_buffer	mimeobj.cpp:287
MimeMessage_parse_line	mimemsg.cpp:240
convert_and_send_buffer	mimebuf.cpp:184
mime_LineBuffer	mimebuf.cpp:272
MimeObject_parse_buffer	mimeobj.cpp:287
mime_display_stream_write	mimemoz2.cpp:946
nsStreamConverter::OnDataAvailable	nsStreamConverter.cpp:938

Comment 7

[David :Bienvenu]

this is fixed by the patch in 473924