Closed Bug 462548 Opened 13 years ago Closed 13 years ago

remove nsIMsgFilterService.h

Categories

(MailNews Core :: Filters, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: mvl, Assigned: mvl)

Details

Attachments

(1 file)

nsIMsgFilterService.h is not build, an .idl file is used instead. The .h should be removed from the tree, to prevent confusion.
Attached patch remove fileSplinter Review
Attachment #345795 - Flags: superreview?(dmose)
Attachment #345795 - Flags: review?
Attachment #345795 - Flags: review? → review?(kent)
Although dmose specifically commissioned me to review the SIEVE patch, that is a fairly narrow mandate. So technically I don't have the authority to review this patch.

But here's what I do, to help the official reviewers. I'm applying your patch, plus I will do a clobber build to make sure that it is OK. Theoretically it looks good, and the clobber build will catch any deficiencies in my theory. Hopefully the official review will be trivial after that. I'll change the reviewer to a real reviewer after I've done that.
Attachment #345795 - Flags: review?(kent) → review?(bienvenu)
My TB debug build worked fine with this file removed.
Comment on attachment 345795 [details] [diff] [review]
remove file

r/sr=me
Attachment #345795 - Flags: superreview?(dmose)
Attachment #345795 - Flags: superreview+
Attachment #345795 - Flags: review?(bienvenu)
Attachment #345795 - Flags: review+
pushed to comm-central: http://hg.mozilla.org/comm-central/rev/1d794dede2f8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.