462549 - Verify that an appcache manifest hasn't changed at the end of an update

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

The offline spec requires that at the end of a successful cache update, we re-download the manifest to make sure it hasn't changed.  This is to prevent us from grabbing a partial snapshot of the app during a server push.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 345762 [details] [diff] [review]
v1

+NS_IMPL_ISUPPORTS4(nsManifestCheck,
+                   nsIRequestObserver,
+                   nsIStreamListener,
+                   nsIChannelEventSink,
+                   nsIInterfaceRequestor);

shouldn't put a semicolon at the end here, some compilers don't like that

+    nsCString foo;
+    foo.Assign(aFromSegment, aCount);

this seems unused?

+    PRUint32 bytesRead = 0;
+    aStream->ReadSegments(ReadManifest, this, aCount, &bytesRead);

you don't have to initialize bytesRead

+    // Redirects should cause the load (and therefore the update) to fail.
+    return NS_ERROR_FAILURE;

you have to allow REDIRECT_INTERNAL redirects here

Comment 2

[Dave Camp (:dcamp)]

Attachment: patch as landed

Includes the review fixes and properly includes the test file.

Comment 3

[Dave Camp (:dcamp)]

Attachment: patch as landed

err, this was the new patch.

Comment 4

[Dave Camp (:dcamp)]

Landed as http://hg.mozilla.org/mozilla-central/rev/037702607ad8