462621 - test_retention_is_0_closes.xul times out and leaks, on my computer

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081031 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

A DM window appears and stays there for a (long) while reporting "Scanning for viruses...";
but I don't have any antivirus software installed.

{
2 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul | Test timed out.
}

It also leaks "the world".

NB: It was succeeding when I ran the tests on 2008-09-17.

Comment 1

[Serge Gautherie (:sgautherie)]

In case it matters, I build with |ac_add_options --disable-vista-sdk-requirements|.

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081103 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)

Same with SeaMonkey (with a TK DLMGR patch).

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20081106 Minefield/3.1b1pre] (home, optim default) (W2Ksp4)

"197f83ad7678 2008-10-07 15:45:10" was succeeding.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> "197f83ad7678 2008-10-07 15:45:10" was succeeding.

"197f83ad7678	2008-10-07 08:45:33 -0700"

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

"28fc43e4394c	2008-10-19 05:37:54 -0700" was already failing.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Same with SeaMonkey (with a TK DLMGR patch).

I also experienced it in a real life case ("opening" a JNLP file).

Comment 6

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081108 Minefield/3.1b2pre] (nightly) (W2Ksp4)

But a nightly works fine...

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081109 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

"f0d87d0a9156	2008-10-13 13:14:36 -0700" was succeeding.

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081109 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

"9fde2bdd93ef	2008-10-16 08:17:07 -0700" was already failing.

Comment 9

[Serge Gautherie (:sgautherie)]

This is caused by bug 459329 checkin.

Comment 10

[[e-mail]]

Strange, because the whole point of bug 459329 was that you couldn't build with --disable-vista-sdk-requirements ...

Can you compare the output of make nsDownloadManager.i with and without the patch?

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> Strange, because the whole point of bug 459329 was that you couldn't build with
> --disable-vista-sdk-requirements ...

I know, though I never had any issue building Firefox (or SeaMonkey) with/without the patch :-|

> Can you compare the output of make nsDownloadManager.i with and without the
> patch?

without:
(nsDownloadScanner.obj size is 72 KB.)
nsDownloadManager.i size is 6,222 KB.

with:
(there is no nsDownloadScanner.obj.)
nsDownloadManager.i size is 5,586 KB.

At first glance (inside the file), it seems the patch does what it's supposed to.
Anything specific that you want me to check ?

Comment 12

[[e-mail]]

Attachment: Proposed patch

We were getting into the DOWNLOAD_SCANNING state without having a scanner...

I haven't actually tested this, but a) Shawn might decide that the patch is sufficiently trivial to review b) Serge might test this for me anyway.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This bug probably explains why every download I've started lately on my Vista system has been getting stuck in a download scanning state even though I don't have a virus scanner installed. I build with --disable-vista-sdk-requirements on VC8SP1. I'll give this patch a shot and see if it fixes that problem for me.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Yup, this patch fixes the problem!

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 347193 [details] [diff] [review]
Proposed patch

(In reply to comment #13)
> This bug probably explains why every download I've started lately on my Vista

That is this bug :->

(In reply to comment #14)
> Yup, this patch fixes the problem!

And bug 463855 to ;-)

Comment 17

[Shawn Wilsher :sdwilsh]

Comment on attachment 347193 [details] [diff] [review]
Proposed patch

ugh, yes.  I missed this in my original review...

r=sdwilsh

Comment 18

[Shawn Wilsher :sdwilsh]

Comment on attachment 347193 [details] [diff] [review]
Proposed patch

This is NPOTDB IMO, so you don't need approval.

Comment 19

[[e-mail]]

Pushed changeset 40fbebff0cd5 to mozilla-central.

Comment 20

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

V.Fixed

Comment 21

[Serge Gautherie (:sgautherie)]

fixed1.9.1 -> verified1.9.1, per comment 20.