46274 - Can't change compose prefs

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Akkana Peck]

From the mail window, open the prefs window and click on Composing Messages.
Change any pref, then click OK.  The dialog doesn't close, the pref doesn't
change, and there's a JS error on the console:

JavaScript error:
chrome://global/content/nsWidgetStateManager.js line 130: elements[i] has no
properties

Comment 1

[Akkana Peck]

Recent regression, should be fixed unless we're going to tell people to quit the
app and edit their prefs.js.

Comment 2

[lchiang]

Yes, this is a recent regression.

Other preference panels are ok.  

Comment 3

[lchiang]

*** Bug 46275 has been marked as a duplicate of this bug. ***

Comment 4

[nhottanscp]

*** Bug 46310 has been marked as a duplicate of this bug. ***

Comment 5

[Akkana Peck]

*** Bug 46301 has been marked as a duplicate of this bug. ***

Comment 6

[John Morrison]

This was Ben Bucksch' checkin. The value "sendStruct" needs to be removed from 
the '_elementIDs' array in 'pref-composing_messages.xul' (to match its removal 
as the id of an element in the XUL). It's a simple fix; any takers?

Comment 7

[Ben Bucksch (:BenB)]

Ops. It's mine, will take it.

Comment 8

[Ben Bucksch (:BenB)]

Could somebody please review?

Comment 9

[Ben Bucksch (:BenB)]

Attachment: Fix

Comment 10

[Ben Bucksch (:BenB)]

readding ducarroz, if he wants to review.

Reviewer: I only tested on Linux.

Comment 11

[John Morrison]

Don't know if I count, but r=jrgm :-]

Comment 12

[Jean-Francois Ducarroz]

Fine with me too. R=ducarroz

Comment 13

[Ben Bucksch (:BenB)]

tnx.

waterson: a?

Comment 14

[Chris Waterson]

a=waterson

Comment 15

[scottputterman]

*** Bug 46370 has been marked as a duplicate of this bug. ***

Comment 16

[Ben Bucksch (:BenB)]

fixed.

Comment 17

[leger]

Putting on [nsbeta2+] radar.  Would like a verification on branch bits please.

Comment 18

[Ben Bucksch (:BenB)]

When did M17 branch? Did this checkin make it into the branch? If not, I don't
know how to move it over.

Comment 19

[John Morrison]

The M17 branch occurred ~4pm PDT Jul 26, so your checkin, from the day 
previous, is part of the code for the M17 branch builds.

At any rate, with 2000072904 M17 branch win32/linux/mac this Verified Fixed.