make |test_interface()| function in |test_recur.js| more robust

RESOLVED FIXED in 3.2

Status

Calendar
Internal Components
P2
normal
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: dbo, Assigned: Fallen)

Tracking

Details

(Whiteboard: [good first bug][mentor=Fallen][lang=js], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Those tests rely on a certain order of the RRULE's parameters which could change.
(Reporter)

Updated

9 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

4 years ago
Priority: -- → P2
Whiteboard: [good first bug][mentor=Fallen][lang=js]
(Assignee)

Comment 1

4 years ago
Created attachment 8384278 [details] [diff] [review]
Fix - v1

This is as far as I think we should fix the test for now. I've replaced exact checks with string/regex checks and it seems to be working, both for ical.js and libical.

This patch also removes enabling ical.js which I accidentally added in bug 973651.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8384278 - Flags: review?(matthew.mecca)
(Assignee)

Comment 2

4 years ago
Created attachment 8384279 [details] [diff] [review]
Fix - v1
Attachment #8384278 - Attachment is obsolete: true
Attachment #8384278 - Flags: review?(matthew.mecca)
Attachment #8384279 - Flags: review?(matthew.mecca)
Comment on attachment 8384279 [details] [diff] [review]
Fix - v1

Review of attachment 8384279 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mmecca

::: calendar/test/unit/test_recur.js
@@ +377,5 @@
>  
>      // deleteRecurrenceItemAt
>      rinfo.deleteRecurrenceItemAt(1);
>      itemString = item.icalString;
> +    dump(itemString);

dump left in intentionally?
Attachment #8384279 - Flags: review?(matthew.mecca) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Matthew Mecca [:mmecca] from comment #3)

> > +    dump(itemString);
> 
> dump left in intentionally?

Nope, thanks for catching that.
(Assignee)

Comment 5

4 years ago
Pushed to comm-central changeset 3d40333df6e2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.