462873 - WinCE Shunt Library Needs To Save Env to Registry

Status: RESOLVED DUPLICATE of bug 465874

(Firefox Build System :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: v1.0 of patch for environment variables saving to Registry

In WinCE Shunt Library, environment variables need to be saved out to Registry.

Environment variables are not properly handed off to a second execution of the xulrunner EXE.  By saving those environment variables to the Registry, all environment variables can be modified, including those specified as "initial value" within the WinCE Shunt Library.

Prior to this patch, those initial value environment variables were not easily modified.

This patch is set up so that the initial values will be used ONLY if the WinCE Shunt Library Registry Key (HKEY_LOCAL_USER/Software/Mozilla/Environment) does not exist.  

Also, I have added a function to purge any cached environment variables, as a way of helping to defragment memory in low memory situations.

Comment 1

[John Wolfe (:wolfe)]

Attachment: v2.0 patch

Remove function header for purgeMappings() function in WinCE Shunt Library.

purgeMappings() function will de-allocate all the cached environment variables, potentially allowing less memory fragmentation in low memory situations.

Removed the __try / except constructs, removed extra indentation on getMapping() function.

Removed TABs accidentally inserted by Visual Studio 2008 (thanks MS!).

Comment 2

[John Wolfe (:wolfe)]

Attachment: v3.0 patch

Made all non-exported functions static, to ensure no use outside of the WinCE Shunt Library.

Added safety checks for allocations, to make sure failed allocs are not attempted to be dereferenced.

Used strdup() instead of malloc()/strcpy() in several places.

Comment 3

[John Wolfe (:wolfe)]

Attachment: v4.0 patch

Removed "convert to registry soon" comment.  Lined up a few equal signs.

Comment 4

[John Wolfe (:wolfe)]

Comment on attachment 346077 [details] [diff] [review]
v4.0 patch

Changing from using Registry to actually using command line to pass environment in WinCE, as per blassey previous patch.

Comment 5

[John Wolfe (:wolfe)]

Resolved in favor of passing whole environment variables to new invocation via command line arguments.