Closed
Bug 462887
Opened 16 years ago
Closed 16 years ago
document ignoreScrollFrame argument in nsLayoutUtils, change it to "ignoreRootScrollFrame"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: Gavin, Assigned: Gavin)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
8.45 KB,
patch
|
roc
:
review+
bzbarsky
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
bz brought this up while reviewing the patch in bug 461803. 1) ignoreScrollFrame is probably clearer as ignoreRootScrollFrame 2) it should be documented in nsLayoutUtils
|
Assignee | |
Updated•16 years ago
|
Summary: document ignoreScrollFrame argument in nsLayoutUtils, rename it ignoreRootScrollFrame → document ignoreScrollFrame argument in nsLayoutUtils, change it to "ignoreRootScrollFrame"
|
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #346989 -
Flags: superreview?
Attachment #346989 -
Flags: review?(roc)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #346989 -
Flags: superreview? → superreview?(bzbarsky)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 346989 [details] [diff] [review] patch s/or not// and looks good.
Attachment #346989 -
Flags: superreview?(bzbarsky) → superreview+
Attachment #346989 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 346989 [details] [diff] [review] patch Simple documentation and member variable name change, should have no risk and no impact to consumers.
Attachment #346989 -
Flags: approval1.9.1?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 346989 [details] [diff] [review] patch a191=beltzner
Attachment #346989 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 5•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/118ca6994ff5
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
||
Updated•15 years ago
|
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•