Closed Bug 462911 Opened 11 years ago Closed 11 years ago

support NS_PRINTING in gfx / cairo

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(3 files)

Attached patch patch v.1Splinter Review
on windows mobile, we would like to build without printing support.  This allows us to avoid alot of windows 32 functions that are not available on windows ce.

This patch simply doesn't compile cairo-win32-printing-surface.c and ensures that we don't call into any cairo printing functions.
Attachment #346114 - Flags: review?(vladimir)
Comment on attachment 346114 [details] [diff] [review]
patch v.1

Looks fine, but don't use NS_PRINTING inside cairo-win32-surface.c -- we really need a CAIRO_HAS_WAN32_PRINTING_SURFACE in cairo, but in the meantime can you use something like CAIRO_OMIT_WIN32_PRINTING and add that to DEFINES?

Also don't forget to put the cairo patch in gfx/src/cairo and add it to the README, or it will be blown away next time a cairo upgrade happens.
Attachment #346114 - Flags: review?(vladimir) → review+
Attached patch patch v.2Splinter Review
Vlad, this is the patch using the correct #define, and creating the request cairo patch file.
Attachment #346260 - Attachment is patch: true
Attachment #346260 - Attachment mime type: application/octet-stream → text/plain
Attached patch makefile fixSplinter Review
and this is why we love our try server.
pushed ce13a614a5dc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.