462911 - support NS_PRINTING in gfx / cairo

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

on windows mobile, we would like to build without printing support.  This allows us to avoid alot of windows 32 functions that are not available on windows ce.

This patch simply doesn't compile cairo-win32-printing-surface.c and ensures that we don't call into any cairo printing functions.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 346114 [details] [diff] [review]
patch v.1

Looks fine, but don't use NS_PRINTING inside cairo-win32-surface.c -- we really need a CAIRO_HAS_WAN32_PRINTING_SURFACE in cairo, but in the meantime can you use something like CAIRO_OMIT_WIN32_PRINTING and add that to DEFINES?

Also don't forget to put the cairo patch in gfx/src/cairo and add it to the README, or it will be blown away next time a cairo upgrade happens.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.2

Vlad, this is the patch using the correct #define, and creating the request cairo patch file.

Comment 3

[Doug Turner (:dougt)]

Attachment: makefile fix

and this is why we love our try server.

Comment 4

[Doug Turner (:dougt)]

pushed ce13a614a5dc