462918 - Tinderbox reports test failure when the builds fail

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

A trunk checkin today made builds fail, but tinderbox reported "test failed"
with the color Orange rather than build failed with the color dark red.
See the log file at
http://tinderbox.mozilla.org/showlog.cgi?log=NSS/1225748037.1225748943.4400.gz&fulltext=1

Comment 1

[Christophe Ravel]

in tinder.sh, the function build_and_test should return 2 different values whether a build failed or a test failed.
Or you could split this function into 2: build and test
- a build failure should return "busted"
- a test failure should return "testfailed"

Comment 2

[Slavomir Katuscak]

Attachment: Patch.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 346480 [details] [diff] [review]
Patch.

I'm not sure this is a complete fix, but it looks like it should be a step in the right direction.
r+

Comment 4

[Slavomir Katuscak]

Checking in tinder.sh;
/cvsroot/mozilla/security/tinderlight/tinder.sh,v  <--  tinder.sh
new revision: 1.2; previous revision: 1.1
done