462969 - Update print preview toolbar icons on windows theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The toolbar icons in the print preview window currently just use monochrome gif images.  We are having these icons updated for XP and Vista, this bug is for landing the new files.

Comment 2

[(no longer active)]

Alex, you marked this as [icon-complete] without attaching any icons either on this bug or its dupe.  What's going on?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

they are complete on my hard drive? sorry about the lag, one sec.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: print preview arrows

These files should probably be checked in to /source/toolkit/themes/winstripe/global/arrow/

We need to continue to package the gif images in 1.9.1 in case any extensions are using them.

for the XP Luna images (not tagged -aero). the states are:

normal / hover

Comment 5

[(no longer active)]

Attachment: Patch (v1)

Comment 6

[Dão Gottwald [:dao]]

Err, no, global/arrow/ is not the dumping place for all sorts of arrows :(
Please add a printpreview folder if needed?

Comment 7

[(no longer active)]

Attachment: Patch (v2)

(In reply to comment #6)
> Err, no, global/arrow/ is not the dumping place for all sorts of arrows :(
> Please add a printpreview folder if needed?

Done.

Comment 8

[Dão Gottwald [:dao]]

Alex, what do you think about adding a hover state to the aero images? It would be identical to the normal state. This way we could use the same style rules the aero and non-aero images. Also, if somebody wants to add a real hover state in the future, the images could be edited and it would just work.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, it slipped my mind that we do that everywhere else, I'll update the aero images so we can keep the style rules simple.

In terms of adding a print preview folder, I don't have a super strong opinion (primary goal is to get these all done in time), but don't we want to encourage image reuse?  Over time people have copied similar images into different areas and given them feature specific names.  Like the same planet icon that is copied and is used for the concepts of Localization packs and and Geolocation.  I guess the overall decision is code modularity versus redundancy?  I'm starting to think that a single dumping ground in toolkit for all images could significantly cut down on our redundancy (for Namoroka).

Comment 10

[Dão Gottwald [:dao]]

If we add a printpreview folder, that's of course not set in stone. When there's another use for these icons, there's always the option to move them, but I don't foresee this right now.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

sounds good, moving icons has implications for extensions but we should probably get th

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

get this sorted out with one big re-factoring at some point in the future.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Updated aero arrows

These duplicate the aero arrows so that each arrow now has twice the aeros.  anyway, now the style rules can be the same between platforms.

Comment 14

[(no longer active)]

Attachment: Patch (v3)

Patch with the new aero icons

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 380607 [details] [diff] [review]
Patch (v3)

>+.home-arrow:hover, .end-arrow[chromedir="rtl"]:hover {

nit: line break after comma. Please fix this for the existing end-arrow, home-arrow, left-arrow and right-arrow selectors as well.

Comment 16

[(no longer active)]

(In reply to comment #15)
> (From update of attachment 380607 [details] [diff] [review])
> >+.home-arrow:hover, .end-arrow[chromedir="rtl"]:hover {
> 
> nit: line break after comma. Please fix this for the existing end-arrow,
> home-arrow, left-arrow and right-arrow selectors as well.

Done.  Landed as <http://hg.mozilla.org/mozilla-central/rev/beb8a6eefb91>

Comment 17

[(no longer active)]

Attachment: 1.9.1 Patch

Comment 18

[(no longer active)]

Attachment: 1.9.1 Screenshot

Screenshot of the patch on 1.9.1.

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 380675 [details] [diff] [review]
1.9.1 Patch

a191=beltzner

Comment 20

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/40b82b8dfc4a

Comment 21

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre ID:20090601044045

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090601 Minefield/3.6a1pre ID:20090601041706

for Windows XP and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre (.NET CLR 3.5.30729) ID:20090601044045

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090601 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090601041706

for Windows Vista