462972 - Fix nsChangeHint comparisons

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

My build fails due to the recent BC change. Basically, operator== should not be used for nsChangeHints.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 346176 [details] [diff] [review]
fix

sr=dbaron

Comment 2

[Bernd]

sorry for breaking your build, but I would really like to learn why your build breaks when tinderbox is green.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We have special "break roc's build" code:
http://mxr.mozilla.org/seamonkey/source/layout/base/nsChangeHint.h#58

This is probably unwise

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think you should remove the ifdefs :-)

Comment 5

[Bernd]

59 // Redefine these operators to return nothing. This will catch any use
60 // of these operators on hints. We should not be using these operators
61 // on nsChangeHints

Robert and now the last incompetent question before I go hiding again, why is this bad? It looks pretty innocent to me.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The intent was that nsChangeHint is a set of bits, and we should be able to add new bits to that set without breaking things by changing existing behaviour.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Sorry for missing this.  :( And yes, I think the ifdefs should just go.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed b282e708accc. I'll leave this open for removing the #ifdefs.

Comment 9

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

I assume the #ifdefs mentioned in comment 8 is #ifdef DEBUG_roc. If so, it was removed in bug 502288.