Closed
Bug 462979
Opened 16 years ago
Closed 16 years ago
[FIX]EventUtils synthesizeMouse is buggy: sends event to wrong place
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
|
17.30 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
In particular, if the element passed in is not aligned to pixel boundaries, it floors the coords instead of rounding. This causes events to be dispatched with the wrong offset relative to the element.
Patch coming up that _should_ fix this (and then enable the test that was failing due to this bug) without causing other tests to go orange. I hope...
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #346190 -
Flags: superreview?(roc)
Attachment #346190 -
Flags: review?(enndeakin)
|
|
Assignee | |
Updated•16 years ago
|
Summary: EventUtils synthesizeMouse is buggy: sends event to wrong place → [FIx]EventUtils synthesizeMouse is buggy: sends event to wrong place
|
|
Assignee | |
Updated•16 years ago
|
Summary: [FIx]EventUtils synthesizeMouse is buggy: sends event to wrong place → [FIX]EventUtils synthesizeMouse is buggy: sends event to wrong place
Attachment #346190 -
Flags: superreview?(roc) → superreview+
|
||
Updated•16 years ago
|
Attachment #346190 -
Flags: review?(enndeakin) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 346190 [details] [diff] [review]
Like so, I hope
Looks OK.
|
|
Assignee | |
Comment 3•16 years ago
|
||
This makes the set of iframe offsets for which this stuff fails much smaller. It's still something like 0.05px wide, which seems too wide to be accounted for by nscoord rounding, but whatever.
Attachment #346190 -
Attachment is obsolete: true
Attachment #346812 -
Flags: review?(roc)
Attachment #346812 -
Flags: superreview+
Attachment #346812 -
Flags: review?(roc)
Attachment #346812 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 346812 [details] [diff] [review]
Better yet
It'd be good to enable these tests for 1.9.1 as well.
Attachment #346812 -
Flags: approval1.9.1?
|
||
Comment 5•16 years ago
|
||
Comment on attachment 346812 [details] [diff] [review]
Better yet
a191=beltzner
Attachment #346812 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 6•16 years ago
|
||
It finally stuck! http://hg.mozilla.org/mozilla-central/rev/525b2f56f1b6
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
|
Assignee | |
Updated•16 years ago
|
Keywords: fixed1.9.1
|
||
Updated•16 years ago
|
Component: Testing → Mochitest
Flags: in-testsuite+
Product: Core → Testing
QA Contact: testing → mochitest
Target Milestone: mozilla1.9.1b3 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•