4631 - [PP]gcc 2.7.2.3 barfage on wallet.cpp

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Greg Roelofs]

Sources pulled 6 Apr 1999 20:00 PST; compiling with gcc 2.7.2.3 under Linux
2.0.36 (Slackware/libc5):

wallet.cpp:172: fixed or forbidden register was spilled.
This may be due to a compiler bug or to impossible asm
statements or clauses.
cpp: output pipe has been closed
make[3]: *** [wallet.o] Error 1
make[3]: Leaving directory `/util/www/mozilla/extensions/wallet/src'

This is wallet_DumpTiming(), which looks pretty harmless to me at first glance,
but who knows.  If it is a gcc bug, this means the Unix build instructions need
to be updated--i.e., 2.7.2.3 is no longer an option.  (My last pull was 14 Mar,
which built successfully.)

Comment 1

[Greg Roelofs]

Sorry, I failed to include the type mismatch warning just before the error; the
following trivial patch fixes the problem:

--- wallet.cpp.stock	Tue Apr  6 17:48:46 1999
+++ wallet.cpp	Wed Apr  7 07:02:30 1999
@@ -162,7 +162,7 @@
   PRInt32 i;
   for (i=1; i<timing_index; i++) {
 #ifndef	XP_MAC
-    fprintf(stdout, "time %c = %ld\n", timingID[i], (timings[i] -
timings[i-1])/100);
+    fprintf(stdout, "time %c = %ld\n", timingID[i], (long)(timings[i] -
timings[i-1])/100);
 #endif
     if (i%20 == 0) {
       wallet_Pause();

Comment 2

[Stephen P. Morse]

This code is wrapped inside an ifdef DEBUG so apparently it is breaking the
debug build only, and the release build is fine.  In that case it's not critical
to fix this before the M4 release (which is already frozen).  I will make the
fix just as soon as M4 branches and the freeze is over.

Comment 3

[Stephen P. Morse]

Fixed as indicated and checked in.

Comment 4

[Paul MacQuiddy]

newt, is all well for you? Please mark verified if you can build now.

Comment 5

[Greg Roelofs]

Sorry, I didn't realize this was still considered open!  All is fine; marking
verified.