463177 - Open "Clear Private Data" dialog from about:privatebrowsing

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

We need to open the CPD dialog from about:privatebrowsing after bug 453440 lands.

This code should most likely be enabled: <http://hg.mozilla.org/mozilla-central/file/a82181a23253/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml#l81>

Comment 1

[(no longer active)]

Alex, the existing text which I had disabled before does not mention "Clear Recent History" as the name of the dialog box which it opens, so I guess we're fine with the current strings (which match the ones in <http://people.mozilla.com/~faaborg/files/shiretoko/privacy_i2.png>).  I'm going to assume this in my patch (which is posted soon), so please let me know if we need to update the strings here.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Alex, the existing text which I had disabled before does not mention "Clear
> Recent History" as the name of the dialog box which it opens, so I guess we're
> fine with the current strings (which match the ones in
> <http://people.mozilla.com/~faaborg/files/shiretoko/privacy_i2.png>).  I'm
> going to assume this in my patch (which is posted soon), so please let me know
> if we need to update the strings here.

Silly me!  That dialog *is* renamed.  Please ignore comment 1 and imagine I never wrote that.  :-)

/me wishes bugzilla had a comment deletion feature...

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Simple enough.

Comment 4

[Johnathan Nightingale [:johnath]]

(In reply to comment #2)
> (In reply to comment #1)
> > Alex, the existing text which I had disabled before does not mention "Clear
> > Recent History" as the name of the dialog box which it opens, so I guess we're
> > fine with the current strings (which match the ones in
> > <http://people.mozilla.com/~faaborg/files/shiretoko/privacy_i2.png>).  I'm
> > going to assume this in my patch (which is posted soon), so please let me know
> > if we need to update the strings here.
> 
> Silly me!  That dialog *is* renamed.  Please ignore comment 1 and imagine I
> never wrote that.  :-)

To be fair, when you wrote it I hadn't yet changed the dialog title.  :)

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 346688 [details] [diff] [review]
Patch (v1)

let's get this in for beta

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/18fec592b35b

Comment 7

[Jim Jeffery not reading bug-mail 1/2/11]

Using the CPD button after entering PB will clear your 'entire' history.  It appears that the new CPD options box does not respect the choice.

Using a test profile that had some history, I browsed a few links to check that history was recent. 

I then entered PB and clicked 'Clear History Button' and chose Clear My History for the last 'hour', however upon exiting PB I found that all the History was gone.  

This bug should be backed out as it would be better for the end user at this point to look out for him/herself with regards to history.  I would be very upset if my 180days of history was to be cleared when I was 'thinking' I was clearing the 'last hour'.  

I did not test the other CPD clearing options that use different time-frames.

Tested using an hourly build with changeset:
http://hg.mozilla.org/mozilla-central/rev/18fec592b35b

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre Firefox/3.0 ID:20081107001016

Comment 8

[Marcia Knous [:marcia]]

I can verify the option appears in the UI using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre, and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre. But as Jim says in Comment 7, the issue of functionality still remains for the time based option.

Comment 9

[(no longer active)]

This is being tracked in bug 453440 which has a reviewed and approved patch waiting to land as we speak.

Comment 10

[Marcia Knous [:marcia]]

Verifying this bug fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081112 Minefield/3.1b2pre as well as Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081112 Minefield/3.1b2pre.

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7412 added to Litmus.

Comment 12

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.