Php WebApp is brittle with unexpected values

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: lars, Assigned: ozten)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
On looking up a crashdump by uuid, the WebApp can display a runtime error with stack trace if the database returns unexpected values. See http://crash-reports-php.stage.mozilla.com/report/index/a88c2b2d-5125-475b-ad30-88f720081104 as an example.

To allow for a future retry of failed jobs and allow a user to see that their job may have failed, the processor adds a record to the jobs table without regard for the success or failure of that job.  When a job fails, NULL values may exist in many of the columns of the reports table.  Simply checking for the column 'success' being true is no guarantee that there are no unexpected NULLs.  

The webapp should be coded to take these unexpected values into account.

Feel free to reassign this bug to a more appropriate person as needed.
(Assignee)

Comment 1

10 years ago
Added check for size of array is valid for index. r 687
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.