463292 - overflowing text-shadow in XUL labels not fully repainted

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Overlapped blur effect

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre

Having multiple lines inside the all tabs or ctrl-tab panel the blurring effect of the preview text is overlapped by the beneath preview box. See the attachment.

Steps:
1. Open at least 4 tabs
2. Click all tabs or ctrl+tab (hold down ctrl key here)
3. Use the mouse to focus a preview in the first row and afterwards the one beneath

You will notice that the bottom area of the preview text is overlapped by the beneath preview.

Comment 1

[Dão Gottwald [:dao]]

roc, is Gecko behaving correctly here?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm confused. I don't see anything wrong in the testcase. By "preview text" do you mean "Minefield Start Page"? What do you think is overlapping it?

Comment 3

[Dão Gottwald [:dao]]

The text-shadow of "Minefield Start Page" is cut off.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Oh that.

That looks like a problem in the overflow area calculation for the XUL text box with shadow, leading to it not being repainted when we repaint the bottom tab preview.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Testcase

Click to see the bug.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

-- Override ComputesOwnOverflowArea to return true so that nsBox::SyncLayout doesn't ignore what we set
-- Make nsDisplayXULTextBox return the overflow area as its bounds

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Roc, can we get a better summary for this bug?

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 349332 [details] [diff] [review]
fix

r+sr=dbaron

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Initially landed on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/fb2326fcfc36
http://hg.mozilla.org/mozilla-central/rev/026147c91538
and then backed out due to crashes caused by bug 430332:
http://hg.mozilla.org/mozilla-central/rev/9eaf91dad68c
and then relanded on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/607791c2f989
and thus fixed on both mozilla-central and releases/mozilla-1.9.1.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081206 Shiretoko/3.1b3pre.

Roc, is it something we can cover in the test-suite?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Right now it's quite difficult to test. But later we'll have the ability to test invalidation properly.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Added as Litmus test meanwhile:
https://litmus.mozilla.org/show_test.cgi?id=7439

Comment 13

[Aakash Desai [:aakashd]]

This bug is NOT FIXED on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081127 Minefield/3.1b3pre ID:20081127040457 and every build after that (verified using testcase #2).

I'd like some discussion on this before its re-opened as the blur is being cut off by the box in that test case.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Do you have a screenshot? It looks fine to me with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090617 Shiretoko/3.5pre ID:20090617031317