get sizereport script working in tamarin-redux

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Dan Schaffer, Assigned: Dan Schaffer)

Tracking

unspecified
x86
Mac OS X
Bug Flags:
wanted-flashplayer10 +
flashplayer-triage +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
there's a backlog item to get sizereport working again in the buildsystem

plan:
- add sizereport.py to generate the sizereport from a map file
- script can write sizereport data to database
- get winmo sizereport working in buildbot
Flags: wanted-flashplayer10+
Flags: flashplayer-triage+
(Assignee)

Comment 1

10 years ago
Created attachment 346734 [details] [diff] [review]
sizereport patch

add patch for sizereport running against windows .map file.
Attachment #346734 - Flags: review?(brbaker)
(Assignee)

Updated

10 years ago
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED

Comment 2

10 years ago
Comment on attachment 346734 [details] [diff] [review]
sizereport patch

--map switch doesn't work in the python script, looks like you need to add map= to the getops

Should actually base this on the x-platform builds instead of on windows VS builds. Add -MAP switch to the OS_LDFLAGS in the configure.py script

I get results if I run the sizereport script, with 16 unknown (not categorized objs). However I do not get a valid size report if I run via the python script

$ ./sizereport.py --map=c:/hg/tamarin-redux/obj-release/shell/avmshell.map
 curr version: unknown
 prev version: unknown
Traceback (most recent call last):
  File "./sizereport.py", line 151, in <module>
    printResultDiff(out)
  File "./sizereport.py", line 90, in printResultDiff
    lastdata[tokens[1]]=int(tokens[0])
ValueError: invalid literal for int() with base 10: './sizereport:'
Attachment #346734 - Flags: review?(brbaker) → review-
(Assignee)

Comment 3

10 years ago
Created attachment 346882 [details] [diff] [review]
sizereport patch
(Assignee)

Updated

10 years ago
Attachment #346734 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Attachment #346882 - Attachment is obsolete: true
(Assignee)

Comment 4

10 years ago
Created attachment 346893 [details] [diff] [review]
sizereport patch

updated sizereport patch, windows cross platform build will build with -MAP flag and sizereport should have all of the object files mapped to categories.
Attachment #346893 - Flags: review?(brbaker)

Updated

10 years ago
Attachment #346893 - Flags: review?(brbaker) → review+
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

10 years ago
finished in changelist 1086 b6e97108512a
(Assignee)

Comment 6

9 years ago
closing bug by marking verified/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.