Closed Bug 463523 Opened 14 years ago Closed 14 years ago

Exptoolbar needs an addrbook.png icon in pinstripe as it is in qute

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: davida, Assigned: davida)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch new icon and jar.mn patch (obsolete) — Splinter Review
This isn't strictly needed for Tb, but not having it breaks exptoolbar on the mac, and it seems a generally useful icon to be able to build on.  The icon itself that's included in this patch is the one from qute.
Attachment #346779 - Flags: review?(philringnalda)
Attachment #346779 - Attachment is patch: true
Attachment #346779 - Attachment mime type: application/octet-stream → text/plain
Attachment #346779 - Flags: review?(philringnalda) → review-
Comment on attachment 346779 [details] [diff] [review]
new icon and jar.mn patch

I'm not sure what that brown thing is, but it's sure not an addressbook - addressbooks look like http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/addrbook/remote-addrbook.png

If you just want to have chrome://messenger/skin/addressbook/icons/addrbook.png load an image that looks like an addressbook in either Qute or Pinstripe, adding |% override chrome://messenger/skin/addressbook/icons/addrbook.png chrome://messenger/skin/addressbook/icons/remote-addrbook.png| in Pinstripe's jar.mn ought to get the job done without needing to add another image (and certainly not that furrin looking one! ;)
And depending on whether you as my sample of one would find it more, or less, confusing, we should maybe switch the Pinstripe parallel to the one use of the /addrbook.png URL in Qute over to using the /addrbook.png alias, instead of having it get to remote-addrbook.png directly.
Sorry, I steered you completely wrong, because our hideous tangle of CSS made me think I understood what it was doing wrong, when I only understood the *other* half of what it was doing wrong.

Rather than add that image, please hg mv mail/themes/pinstripe/mail/addrbook/addressbook-sidebar.png to addrbook.png, change the name in jar.mn, and change the name in the two spots in CSS where it's used.

I'll either hack out all the unused and bogus CSS that threw me off track in another bug, or drink until those brain cells go on to a better place.
Attached patch as requestedSplinter Review
here ya go.  check it in if it works for you.
Attachment #346779 - Attachment is obsolete: true
Attachment #346849 - Flags: review?(philringnalda)
Comment on attachment 346849 [details] [diff] [review]
as requested

Beauty.
Attachment #346849 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/f17d699111be
Assignee: nobody → david.ascher
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.