463648 - When configuring mozilla with a relative path, make check fails in js/src

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Benjamin Smedberg]

I don't usually use client.mk to build, but rather run ../src/configure directly.

This causes `make check` to fail in js/src:

/usr/bin/python ../../../src/js/src/config/check-sync-dirs.py ../../../src/js/src/config ../src/config
TEST-FAIL | build file copies are not in sync
file(s) found in: /builds/mddepend-removal/src/js/src/config
differ from their originals in: /builds/mddepend-removal/ff-release-m32/js/src/config

This is caused by the toplevel configure passing --with-sync-build-files=../src

It should use an absolute path instead of a relative path.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 463648: Pass absolute path to js/src/configure --with-sync-build-files

Comment 2

[Benjamin Smedberg]

This was pushed to tracemonkey and will come back to mozilla-central at the next merge.

Comment 3

[Jim Blandy :jimb]

Merged to mozilla-central without apparent incident.

Comment 4

[Benjamin Smedberg]

Not sure how tracemonkey patches are getting to 1.9.1, but this needs to land in 1.9.1.

Comment 5

[Benjamin Smedberg]

jim, can you push this to 1.9.1?

Comment 6

[Jim Blandy :jimb]

Landed in 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7cad83a4f30a

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Merged to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6c75d8666e90