nativegen.py fails on some versions of Python 2.5

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.01 KB, patch
Brent Baker
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 346932 [details] [diff] [review]
Patch

Apparently Python 2.5 doesn't guarantee uniform handling of NaN and Inf/-Inf conversions across all platforms (it depends on the underlying C library) so some versions fail with the existing script (in particular, the native Windows version from python.org was reported to be failing). Python 2.6 corrects this but we'd rather not require that version just yet.

Attached patch uses a hacky but apparently-functional workaround... tested only on Mac and the abovementioned Windows version. (Not yet tested on cygwin, ActiveState, or Linux builds.)
Attachment #346932 - Flags: review?(brbaker)
(Assignee)

Comment 1

9 years ago
Created attachment 346999 [details] [diff] [review]
Patch #2

Further tweaks to account for more Windows weirdnesses.
Attachment #346932 - Attachment is obsolete: true
Attachment #346999 - Flags: review?(brbaker)
Attachment #346932 - Flags: review?(brbaker)

Comment 2

9 years ago
Comment on attachment 346999 [details] [diff] [review]
Patch #2

Check on windows cygwin and python.org. Looks like you have already tested the patch in the sandbox and looks good.
Attachment #346999 - Flags: review?(brbaker) → review+
(Assignee)

Comment 3

9 years ago
pushed to redux as changeset:   1076:5a6e728e05ee
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.