463722 - Clicking url bar is slow

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

I find it very disorienting when i tap the url bar and then I'm not sure if i hit it or not.
Reason for that is that it takes 1second for the click event to compute, meanwhile the ui is frozen.
I propose making the autocomplete popup a timeout with 200ms delay to let the cursor show up(this click event only takes 275ms). http://hg.mozilla.org/mobile-browser/diff/42fa8bf91ff6/chrome/content/browser-ui.js#805

Comment 1

[(dormant account)]

Attachment: breakup onclick so it doesn't freeze ui for 1second

This doesn't make things go faster, just makes ui more responsive.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 347325 [details] [diff] [review]
breakup onclick so it doesn't freeze ui for 1second

BrowserUI.updateAutoComplete will call updateSearchEngines() one at and then call showHistoryPopup() on the edit control. I assume it's showing the history popup that is slow, since the search engine update is a one time call.

This fix is fine for now, but we might want to look at the history popup code too.

Comment 3

[(dormant account)]

pushed http://hg.mozilla.org/mobile-browser/rev/3c70c11feb6d

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED (<1 second wait time for elements clicked on the url bar) On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4