If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Gloda autocomplete error when no "popular" contacts/identities exist [this.identityCollection is undefined]

RESOLVED FIXED in Thunderbird 3.0b1

Status

MailNews Core
Backend
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: asuth, Assigned: asuth)

Tracking

Trunk
Thunderbird 3.0b1
Bug Flags:
blocking-thunderbird3.0b1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 347039 [details] [diff] [review]
v1 evaluate to undefined rather than dereferencing

When gloda is started with a clean database and has not made any contacts be popular, the query for popular contacts will return with 0 contacts.  Accordingly, there will be no identity sub-collection associated, which means that glautocomp's cleverness in attempting to fish out the identity collection will fail.  I had already dealt with this partially, but was in a rush and didn't get it all.

This fix is the one I discussed with davida.  In a nutshell, it's okay to pass undefined to concat, and we use && in order to short-circuit return undefined rather than attempting to dereference it.
Attachment #347039 - Flags: review?(dmose)
Comment on attachment 347039 [details] [diff] [review]
v1 evaluate to undefined rather than dereferencing

r=dmose, conditional on adding a comment explaining what's going on
Attachment #347039 - Flags: review?(dmose) → review+
(Assignee)

Updated

9 years ago
Blocks: 464354
(Assignee)

Comment 2

9 years ago
Created attachment 348852 [details] [diff] [review]
v2 evaluate to undefined rather than dereferencing

added requested comment, carrying forward r=dmose.
Assignee: nobody → bugmail
Attachment #347039 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #348852 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed

Comment 3

9 years ago
blocking b1
Flags: blocking-thunderbird3.0b1+
Target Milestone: --- → Thunderbird 3.0b1
Checked in: http://hg.mozilla.org/comm-central/rev/e5d97c6bdbce
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.