Closed
Bug 463777
Opened 16 years ago
Closed 16 years ago
Gloda autocomplete error when no "popular" contacts/identities exist [this.identityCollection is undefined]
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(1 file, 1 obsolete file)
1.66 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
When gloda is started with a clean database and has not made any contacts be popular, the query for popular contacts will return with 0 contacts. Accordingly, there will be no identity sub-collection associated, which means that glautocomp's cleverness in attempting to fish out the identity collection will fail. I had already dealt with this partially, but was in a rush and didn't get it all. This fix is the one I discussed with davida. In a nutshell, it's okay to pass undefined to concat, and we use && in order to short-circuit return undefined rather than attempting to dereference it.
Attachment #347039 -
Flags: review?(dmose)
Comment 1•16 years ago
|
||
Comment on attachment 347039 [details] [diff] [review] v1 evaluate to undefined rather than dereferencing r=dmose, conditional on adding a comment explaining what's going on
Attachment #347039 -
Flags: review?(dmose) → review+
Assignee | ||
Comment 2•16 years ago
|
||
added requested comment, carrying forward r=dmose.
Assignee: nobody → bugmail
Attachment #347039 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #348852 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 3•16 years ago
|
||
blocking b1
Flags: blocking-thunderbird3.0b1+
Target Milestone: --- → Thunderbird 3.0b1
Comment 4•16 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/e5d97c6bdbce
You need to log in
before you can comment on or make changes to this bug.
Description
•